fix: use submitted_file instead of undefined filename in uploadXls error response#362
Open
Vinay152003 wants to merge 2 commits intoEAPD-DRB:mainfrom
Open
fix: use submitted_file instead of undefined filename in uploadXls error response#362Vinay152003 wants to merge 2 commits intoEAPD-DRB:mainfrom
Vinay152003 wants to merge 2 commits intoEAPD-DRB:mainfrom
Conversation
…ror response The filename variable is only defined inside the if branch when the file extension is valid. In the else branch (invalid extension), referencing filename causes a NameError crash. Using submitted_file instead, which is always defined from the request, fixes the crash. Fixes EAPD-DRB#360
github-actions
bot
added
the
needs-intake-fix
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a
NameErrorcrash inuploadXls()when an uploaded file has an invalid extension.Root cause: The
filenamevariable is only defined inside theifbranch (viasecure_filename()), but theelsebranch (invalid extension) also referencesfilenameon line 644. If the first uploaded file has an invalid extension,filenameis never assigned, causing the server to crash.Changes
API/Routes/Upload/UploadRoute.pyline 644:filename→submitted_fileTest plan
.xlsxfile — verify success response includes correct template name.txt) — verify error response returns without crashFixes #360
@SeaCelo