Adding support for CDF5 types for put_vars* calls with PnetCDF #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support for put_vars*() calls using PnetCDF with CDF5 types
Contributor
Author
|
Without this change, calls using CDF5 types (e.g. PIOc_put_vars_uchar(), PIOc_put_vars_longlong() etc ) will fail for the PnetCDF I/O type (with an error message similar to the one shown below), |
Adding put_vars*() tests for CDF5 types.
jayeshkrishna
force-pushed
the
jayeshkrishna/add_put_vars_cdf5_pnetcdf_support
branch
from
c0f5b85 to
c4d8bc3
Compare
amametjanov
approved these changes
Dec 9, 2025
Member
amametjanov
left a comment
amametjanov
left a comment
There was a problem hiding this comment.
Thanks. This fixes errors in Omega CTest IO_TEST with pnetcdf as default.
Contributor
Author
|
Thanks @amametjanov for reporting the issue and noting the missing switch cases for the CDF5 types! |
12 tasks
jayeshkrishna
added a commit
that referenced
this pull request
Dec 9, 2025
…evelop (PR #670) Adding support for CDF5 types for PIOc_put_vars*() calls with PnetCDF Also adding C tests with PIOc_put_vars*() calls using CDF5 types. * jayeshkrishna/add_put_vars_cdf5_pnetcdf_support: Adding put_vars*() test for CDF5 types Adding missing support for CDF5 types for PnetCDF
jayeshkrishna
added a commit
that referenced
this pull request
Dec 11, 2025
…d_put_vars_cdf5_pnetcdf_support Adding support for CDF5 types for PIOc_put_vars*() calls with PnetCDF Also adding C tests with PIOc_put_vars*() calls using CDF5 types. (See PR #670 for these changes being merged to master)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for CDF5 types for PIOc_put_vars*() calls
with PnetCDF
Also adding C tests with PIOc_put_vars*() calls using CDF5
types.