Skip to content

Add bootloader configs, ISO profile, and integrate with build script/README#5

Open
Dzodah8772 wants to merge 1 commit intomainfrom
codex-9k7p3m
Open

Add bootloader configs, ISO profile, and integrate with build script/README#5
Dzodah8772 wants to merge 1 commit intomainfrom
codex-9k7p3m

Conversation

@Dzodah8772
Copy link
Owner

Motivation

  • Provide a complete archiso profile including bootloader pieces so the generated ISO can boot on BIOS and UEFI systems.
  • Centralize ISO metadata and boot mode configuration to make builds reproducible and configurable.
  • Integrate bootloader/profile artifacts into the existing build and container workflows for easier local and CI/containerized builds.

Description

  • Add a profiledef.sh file with ISO metadata (iso_name, iso_label, iso_version, bootmodes, etc.) to drive archiso profile settings.
  • Add BIOS and UEFI bootloader configs under boot/ including boot/isolinux/isolinux.cfg and systemd-boot files in boot/efiboot/loader/ and boot/efiboot/loader/entries/archflux.conf.
  • Update scripts/build.sh to copy profiledef.sh and the boot/ directory into the generated profile and preserve existing behavior for packages.x86_64 and airootfs/.
  • Include supporting repository artifacts and documentation: add packages.x86_64 sample package list, airootfs/ overlays (/etc/hostname, /etc/motd, /root/.bashrc), a Dockerfile for containerized builds, and .gitignore entries; update README.md to document profiledef.sh and boot/ inputs and quick-start build instructions.

Testing

  • No automated tests were run.

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15dc46d22d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +45 to +48
if [[ -d "boot/isolinux" ]]; then
rm -rf "$PROFILE_NAME"/isolinux
cp -r boot/isolinux "$PROFILE_NAME"/isolinux
fi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep syslinux modules when overriding isolinux

This block deletes the template isolinux/ directory and replaces it with the repo copy, which only contains isolinux.cfg. In the releng profile, isolinux/ also includes required Syslinux binaries/modules (e.g., isolinux.bin, ldlinux.c32, menu.c32). Removing them makes BIOS boot fail at runtime. Consider copying just isolinux.cfg (or merging) instead of replacing the whole directory so the bootloader binaries stay present.

Useful? React with 👍 / 👎.

Comment on lines +50 to +52
if [[ -d "boot/efiboot" ]]; then
rm -rf "$PROFILE_NAME"/efiboot
cp -r boot/efiboot "$PROFILE_NAME"/efiboot

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve UEFI bootloader binaries in efiboot

Here the script deletes the releng efiboot/ directory and replaces it with the repo copy, which only provides loader config/entries. The releng profile also ships the EFI bootloader binaries (e.g., EFI/BOOT/BOOTx64.EFI from systemd-boot). Removing those files results in a UEFI-bootable ISO that lacks the actual bootloader. Copy or overlay just the config files so the EFI binaries remain.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant