Add bootloader configs, ISO profile, and integrate with build script/README#5
Add bootloader configs, ISO profile, and integrate with build script/README#5Dzodah8772 wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15dc46d22d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [[ -d "boot/isolinux" ]]; then | ||
| rm -rf "$PROFILE_NAME"/isolinux | ||
| cp -r boot/isolinux "$PROFILE_NAME"/isolinux | ||
| fi |
There was a problem hiding this comment.
Keep syslinux modules when overriding isolinux
This block deletes the template isolinux/ directory and replaces it with the repo copy, which only contains isolinux.cfg. In the releng profile, isolinux/ also includes required Syslinux binaries/modules (e.g., isolinux.bin, ldlinux.c32, menu.c32). Removing them makes BIOS boot fail at runtime. Consider copying just isolinux.cfg (or merging) instead of replacing the whole directory so the bootloader binaries stay present.
Useful? React with 👍 / 👎.
| if [[ -d "boot/efiboot" ]]; then | ||
| rm -rf "$PROFILE_NAME"/efiboot | ||
| cp -r boot/efiboot "$PROFILE_NAME"/efiboot |
There was a problem hiding this comment.
Preserve UEFI bootloader binaries in efiboot
Here the script deletes the releng efiboot/ directory and replaces it with the repo copy, which only provides loader config/entries. The releng profile also ships the EFI bootloader binaries (e.g., EFI/BOOT/BOOTx64.EFI from systemd-boot). Removing those files results in a UEFI-bootable ISO that lacks the actual bootloader. Copy or overlay just the config files so the EFI binaries remain.
Useful? React with 👍 / 👎.
Motivation
Description
profiledef.shfile with ISO metadata (iso_name,iso_label,iso_version,bootmodes, etc.) to drivearchisoprofile settings.boot/includingboot/isolinux/isolinux.cfgand systemd-boot files inboot/efiboot/loader/andboot/efiboot/loader/entries/archflux.conf.scripts/build.shto copyprofiledef.shand theboot/directory into the generated profile and preserve existing behavior forpackages.x86_64andairootfs/.packages.x86_64sample package list,airootfs/overlays (/etc/hostname,/etc/motd,/root/.bashrc), aDockerfilefor containerized builds, and.gitignoreentries; updateREADME.mdto documentprofiledef.shandboot/inputs and quick-start build instructions.Testing
Codex Task