fix: resolve race condition causing crash on macOS theme changes #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Dygmalab#1085 Fixed a critical race condition where the nativeTheme event listener was not properly removed when the window closed on macOS. This caused the app to crash when the OS automatically switched between light/dark modes while the app was running in the background without a window. Changes: - Changed onThemeChange from higher-order function to direct function reference to allow proper event listener removal - Added null and isDestroyed checks in sendToRenderer to prevent accessing webContents on destroyed windows - Added comprehensive unit tests for theme.ts and sendToRenderer.ts (20 tests total) The bug occurred because: 1. On macOS, the app stays running when all windows are closed 2. The nativeTheme listener was never removed due to function reference mismatch 3. When macOS auto-switched themes, the event fired with null window 4. Attempting to access window.webContents caused the crash Signed-off-by: Dustin Bone <dustinbone1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1085
Fixed a critical race condition where the nativeTheme event listener was not properly removed when the window closed on macOS. This caused the app to crash when the OS automatically switched between light/dark modes while the app was running in the background without a window.
Changes:
The bug occurred because: