Feat pair wavefunction #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store the jastrow coefficients column major to avoid
v_{ij}\neq v_{ji}.
(style) Fixed warnings
Offset is not required since we do not store the zeros.
Some progress was made on the pair-wavefunction. Convergence is still bad, this commit brings another test to find the bug.
Also checked at the value for the error estimation.
Better rando state proposition. Tried to fix the correlation time issue but it did not work.
Still doesn't work.
Normalisation of <O> and <HO> happens at the exit of compute_mean_energy. For some reason, the pfaffian part of these vectors need to be normalised again, I can't understand why.
This commit fixes the convergence issue. - Bad reference to <O> and <HO> in mapto_pairwf - Implemented ExactSum. - Analytical confirmation of <HO>, <O>, <OO> and S.
These tests are for <O>, <HO> and <OO>. They are based on analytical computations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a good implementation of the pair-wavefunction ansatz. It works by leveraging the general ansatz with copies. We achieved convergence for both general and pair-wf ansatz.
Ready to merge.