Scheme Names #979
Merged
Scheme Names #979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Also do we want to include the 2FA scheme from ASP.NET Identity? |
maartenba
commented
Jan 16, 2026
maartenba
commented
Jan 16, 2026
maartenba
commented
Jan 16, 2026
AndersAbel
reviewed
Jan 16, 2026
| | Feature | Standalone IdentityServer | With ASP.NET Identity | | ||
| | :----------------------- | :---------------------------------------------------------------------------------------- | :------------------------------------------------------------------- | | ||
| | **Main Auth Cookie** | `"idsrv"`<br/>(`IdentityServerConstants.DefaultCookieAuthenticationScheme`) | `"Identity.Application"`<br/>(`IdentityConstants.ApplicationScheme`) | | ||
| | **External Auth Cookie** | `"idsrv.external"`<br/>(`IdentityServerConstants.ExternalCookieAuthenticationScheme`) | `"Identity.External"`<br/>(`IdentityConstants.ExternalScheme`) | |
Member
|
@maartenba You're too fast on the merge button... please see review comments. Also I want to bring up another idea I had in the past: In the IdentityServer AddIdentity method I think we should tap into the scheme collection and remove the idsrv and Identity.External cookies. With the current code, those non-used scheme are still configured. So if anyone incorrectly uses those scheme names when setting configuration it will not fail, because the schemes exist. If we removed them, any incorrect code would instead fail. |
Member
Author
|
Updating as we speak! |
Member
Author
|
@AndersAbel fix PR -> #981 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know it's been a while since you logged #367, but is this what you were thinking of @AndersAbel?
Not entirely sure about location in the docs hierarchy but this seemed most logical (but not fully).
Fixes #367