fix(tdx-attest): align dummy.rs API with linux.rs for musl builds #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dummy.rs module is used when building for non-GNU targets like x86_64-unknown-linux-musl. However, the function signatures didn't match linux.rs, causing compilation failures: 1. `get_quote` signature mismatch: - linux.rs: `get_quote(report_data: &TdxReportData) -> Result<Vec<u8>>` - dummy.rs: `get_quote(_report_data: &TdxReportData, _att_key_id_list: Option<&[TdxUuid]>) -> Result<(TdxUuid, Vec<u8>)>` 2. Unused import `cc_eventlog::TdxEventLog` (TdxEventLog doesn't exist in cc_eventlog, only TdxEvent does) This fix aligns dummy.rs with linux.rs to enable musl static builds, which are useful for cross-distro binary compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
get_quotesignature to match linux.rscc_eventlog::TdxEventLogimportProblem
When building for
x86_64-unknown-linux-musltarget, the code fails to compile because:dummy.rsis selected (sincetarget_env != "gnu")get_quotefunction signature indummy.rsdoesn't matchlinux.rsdstack-attestcallstdx_attest::get_quote(report_data)with 1 argument, butdummy.rsexpects 2Error:
Solution
Align
dummy.rsAPI signatures withlinux.rs:get_quote(report_data: &TdxReportData) -> Result<Vec<u8>>Use Case
This enables building static binaries with musl for better cross-distro compatibility. For example, binaries built on Ubuntu with glibc 2.39 don't work on RockyLinux 9 which has glibc 2.34. Static musl builds solve this.