fix(vmm): use custom gateway URL for dashboard when VM has custom kms/gw endpoints #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvinwang
force-pushed
the
fix/vmm-dashboard-url-custom-gateway
branch
from
c3b66e1 to
223f366
Compare
…/gw endpoints When a VM is configured with custom gateway_urls, the dashboard URL (app_url) should use the custom gateway's host and port instead of the global gateway config. This fixes the issue where VMs with custom kms/gw endpoints would show incorrect dashboard URLs pointing to the default gateway. The fix uses the url crate to parse the first gateway URL from the VM's custom gateway_urls and extracts the host and port to construct the correct dashboard URL.
kvinwang
force-pushed
the
fix/vmm-dashboard-url-custom-gateway
branch
from
223f366 to
52a8ec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a VM is configured with custom
gateway_urls, the dashboard URL (app_url) now correctly uses the custom gateway's host and port instead of the global gateway config.Problem
Previously, VMs with custom kms/gw endpoints would show incorrect dashboard URLs pointing to the default gateway, even though they were configured to use a different gateway.
Solution
The fix parses the first gateway URL from the VM's custom
gateway_urlsand extracts the host and port to construct the correct dashboard URL:gateway_urls: use the host/port from the first custom URLTest plan
--gateway-url https://custom-gateway.example.com:9202