Revert fbitset bump due to ABI incompatibility with libparenth#18
Closed
Copilot wants to merge 3 commits intodependabot/submodules/deps/fbitset-3a54534from
Closed
Revert fbitset bump due to ABI incompatibility with libparenth#18Copilot wants to merge 3 commits intodependabot/submodules/deps/fbitset-3a54534from
Copilot wants to merge 3 commits intodependabot/submodules/deps/fbitset-3a54534from
Conversation
Co-authored-by: chenpeizhi <8114085+chenpeizhi@users.noreply.github.com>
Co-authored-by: chenpeizhi <8114085+chenpeizhi@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Bump deps/fbitset from 7d18fd7 to 3a54534
Revert fbitset bump due to ABI incompatibility with libparenth
Nov 1, 2025
Pull Request Test Coverage Report for Build 19003164134Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dependabot fbitset bump from
7d18fd7to3a54534causes segmentation faults in tests due to ABI-breaking changes incompatible with libparenth.Root Cause
fbitset
3a54534(Oct 2019) introduced breaking changes:int→size_tlibparenth (last updated Sep 2019, commit
2093109) predates these changes and depends on fbitset1f1a3db. When libparenth's template code compiles against the new fbitset headers, the ABI mismatch causes crashes inBsums_it::incrduring Python object division operations.Changes
deps/fbitsetfrom3a54534→7d18fd7Path Forward
To upgrade fbitset, libparenth must first be updated for compatibility with fbitset ≥ Oct 2019.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.