Skip to content

Revert fbitset bump due to ABI incompatibility with libparenth#18

Closed
Copilot wants to merge 3 commits intodependabot/submodules/deps/fbitset-3a54534from
copilot/sub-pr-9
Closed

Revert fbitset bump due to ABI incompatibility with libparenth#18
Copilot wants to merge 3 commits intodependabot/submodules/deps/fbitset-3a54534from
copilot/sub-pr-9

Conversation

Copy link
Contributor

Copilot AI commented Nov 1, 2025

The Dependabot fbitset bump from 7d18fd7 to 3a54534 causes segmentation faults in tests due to ABI-breaking changes incompatible with libparenth.

Root Cause

fbitset 3a54534 (Oct 2019) introduced breaking changes:

  • Size type: intsize_t
  • Iterator internals reworked
  • N_LIMBS made dynamically calculated

libparenth (last updated Sep 2019, commit 2093109) predates these changes and depends on fbitset 1f1a3db. When libparenth's template code compiles against the new fbitset headers, the ABI mismatch causes crashes in Bsums_it::incr during Python object division operations.

Changes

  • Reverted deps/fbitset from 3a545347d18fd7
  • Undid experimental setup.py include path changes

Path Forward

To upgrade fbitset, libparenth must first be updated for compatibility with fbitset ≥ Oct 2019.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits November 1, 2025 21:52
Co-authored-by: chenpeizhi <8114085+chenpeizhi@users.noreply.github.com>
Co-authored-by: chenpeizhi <8114085+chenpeizhi@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 1, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • julialang-s3.julialang.org
    • Triggering command: /home/REDACTED/work/gristmill/gristmill/.venv/bin/python /home/REDACTED/work/gristmill/gristmill/.venv/bin/pytest tests -v (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Bump deps/fbitset from 7d18fd7 to 3a54534 Revert fbitset bump due to ABI incompatibility with libparenth Nov 1, 2025
Copilot AI requested a review from chenpeizhi November 1, 2025 21:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19003164134

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+91.2%) to 91.198%

Totals Coverage Status
Change from base Build 19002992482: 91.2%
Covered Lines: 1782
Relevant Lines: 1954

💛 - Coveralls

@dependabot dependabot bot deleted the branch dependabot/submodules/deps/fbitset-3a54534 November 10, 2025 01:04
@dependabot dependabot bot closed this Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants