Skip to content

Installation and usage instructions updated#17

Closed
Wholinator wants to merge 3 commits intogh-pagesfrom
pages_update_3.9
Closed

Installation and usage instructions updated#17
Wholinator wants to merge 3 commits intogh-pagesfrom
pages_update_3.9

Conversation

@Wholinator
Copy link
Collaborator

Meticulous installation and usage instructions are included.
Instructions for:

  • Installation Script
  • Manual Installation
  • Usage with VSCode
    These are all labeled as "Local Installation" or "Development" usage.

Copy link
Collaborator

@gauravharsha gauravharsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really comprehensive documentation. But perhaps it is a bit too simplified in some places.

For instance, we should not ask user to navigate to the drudge directory and then launch VSCode. This should not be required if the install command is executed properly and with permissions.

Alternatively, if one can only manage to build and not install the files, I prefer (and you have already included) the use of PYTHONPATH environment variable.

install.md Outdated
python3 setup.py build
python3 setup.py install
```
The first two lines set necessary environment variables, so python knows where to find our python imports, and to utilize local dummy_spark instead of apache spark (which isn't quite working on python3.9 yet).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should include a "Known Issues" section in the README.md or install.md to note incompatibilities like apache spark.

Comment on lines +118 to +119
cp build/lib.linux-x86_64-cpython-39/drudge/wickcore.cpython-39-x86_64-linux-gnu.so drudge/
cp build/lib.linux-x86_64-cpython-39/drudge/canonpy.cpython-39-x86_64-linux-gnu.so drudge/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the copying of compiled CPython libraries is not required if python setup.py install is successfully executed. @Wholinator can you double check?

install.md Outdated
Comment on lines +144 to +147
### That's it!
It should be completely installed now. If you now run `code .` from the drudge base directory you'll open a vscode window with the conda environment activated, the environment variables set, and the correct interpreter selected.

If you should close this vscode window and want to open it again you'll need to do a couple steps
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing as above -- if drudge is "installed" in the Conda site-packages, you can pretty much open VSCode from anywhere and import drudge and related submodules.

Comment on lines +155 to +156
### 2) Conda Environment Activated
In the terminal in the bottom portion of the window (you can open with `ctrl/cmd + ~` if it's closed) with the `TERMINAL` tab selected you should see your command prompt. At the very left there might be some things in parenthesis like `(drudge) (base)`. You want to ensure that your drudge environment name is here. If it's not, simply run
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@chenpeizhi
Copy link
Collaborator

We should eventually consider using a more robust solution, e.g., pixi. But I agree that for now this ad hoc solution should be good enough to move us forward.

…ent to copy compiled shared object files with updated pythonpath requirement, removed language assuming vscode usage
@chenpeizhi
Copy link
Collaborator

chenpeizhi commented Jul 23, 2025

As we chatted about in person, the pyproject.toml is now the standard way of specifying Python dependencies. See PEP 518, PEP 517, PEP 621, and PEP 660. It's supported by pip and other modern package managers like uv, Poetry, and PDM. There are plenty of tutorials online on how to write a pyproject.toml file, including this official guide: https://packaging.python.org/en/latest/guides/writing-pyproject-toml/.

@chenpeizhi chenpeizhi self-requested a review July 23, 2025 23:46
@chenpeizhi
Copy link
Collaborator

Superseded by #22

@chenpeizhi chenpeizhi closed this Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants