Added unit tests to viewport decorator to cover interaction with LU button components.#281
Open
alvinhuynh wants to merge 6 commits intoDroppe:masterfrom
yifanz:master
Open
Added unit tests to viewport decorator to cover interaction with LU button components.#281alvinhuynh wants to merge 6 commits intoDroppe:masterfrom yifanz:master
alvinhuynh wants to merge 6 commits intoDroppe:masterfrom
yifanz:master
Conversation
added 6 commits
November 12, 2012 17:58
It now covers previous/next button clicks.
Forgot to undo change I made when testing locally on IE.
I fixed timing issues introduced in the last commit when I added more unit tetsts regarding button components.
Author
|
Travis build initially failed, but updated code to latest from main branch and they seem to all pass now. |
ghost
assigned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit tests now include checks for clicking on "next" and "previous" buttons inside carousel/list components that use our viewport decorator.