Disable sync, export buttons while running sync

[joelwilson]

Related to #198 but expanded to disable the "sync" button during processing as well. Please let me know if there is a different preferred way to do this or if I missed something critical. :)

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[DropSnorz]

Thanks for your contribution! ❤

Unfortunately, this won't work well; the task management is quite a mess today. This part of the app is outdated and requires some refactoring. The main problem is that you can have only one callback per task when registered with task.setOnSucceeded(cb).

It will conflict with some task chaining handled by the factory, here for example: https://github.com/DropSnorz/OwlPlug/blob/cb6d75b15c7f39a4596c3c36961debba5e8476e5/owlplug-client/src/main/java/com/owlplug/plugin/components/PluginTaskFactory.java#L113C14-L113C28

When plugins are synchronized/scanned, it also triggers a resync of file metadata and project sync. But today most controllers are notified of the end of a task thanks to a global notifyListeners() callback.

A way to achieve this without reworking the entire task management could be to make sure that notifyListeners() is called for every event (onSucceeded, onFailed, onCancelled). And then, in each controller registered as a listener, re-enable the buttons. For example, on the PluginsController:

    taskFactory.addSyncPluginsListener(() -> {
      this.displayPlugins();
      syncButton.setDisable(false);
      exportButton.setDisable(false);
    });