Skip to content

Conversation

@Pacodastre
Copy link
Contributor

Also fixes the active users bug in the pie chart.

Two things to note here:

  • at least when running pnpm dev, the progress bars for cpu and ram usage don't load properly at first, but work fine after a few seconds.
  • some error appears in the terminal intermittently. It might be related the websocket being disconnected/reconnected, i'm not 100% sure.
ERROR  [unhandledRejection] Failed to catch-up listener: callback does not exist
    at Object.catchupListener (.nuxt/dev/index.mjs:1:381909)
    at Timeout._onTimeout (.nuxt/dev/index.mjs:1:382028)
    at listOnTimeout (node:internal/timers:608:17)
    at process.processTimers (node:internal/timers:543:7)
userId:  8e03afaf-15d5-4eab-9be8-ae59eaa3a352
id:  3395e664-da84-4709-a1d9-0792789862d0
listers:  Map(1) {
  '8e03afaf-15d5-4eab-9be8-ae59eaa3a352' => Map(1) {
    '3340736d-f8f2-4b62-b70a-a56a8970c992' => { callback: [Function (anonymous)], acls: [Array] } } }

Here's a screenshot the update:

Screenshot From 2025-12-05 00-08-55

@DecDuck
Copy link
Member

DecDuck commented Dec 5, 2025

Just threw up a review of this PR, got some questions about it.

@DecDuck
Copy link
Member

DecDuck commented Dec 19, 2025

How's this PR going?

@Pacodastre
Copy link
Contributor Author

Pacodastre commented Dec 19, 2025 via email

@DecDuck
Copy link
Member

DecDuck commented Jan 19, 2026

Any updates?

@Pacodastre
Copy link
Contributor Author

I'm getting back to it today. I'll update the PR when it's ready.

@Pacodastre Pacodastre force-pushed the system-data-tile-on-admin-home-page branch 2 times, most recently from a1f5974 to 978d9f6 Compare January 21, 2026 02:59
Copy link
Member

@DecDuck DecDuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just some final touches :)

@DecDuck
Copy link
Member

DecDuck commented Jan 21, 2026

Just *three things:

  • I took a look and it seems like you can totally remove the acl properties for the systemManager, and then we can get right of the extra ACL fetch in the websocket route:
-      { callback: (systemData: SystemData) => void; acls: GlobalACL[] }
+      { callback: (systemData: SystemData) => void  }
-    this.listeners.get(userId)!!.set(id, { callback, acls });
+    this.listeners.get(userId)!!.set(id, { callback });

etc...

  • We need to do a pushUpdate on connecting otherwise we have to wait until we get the first UI update
  • Updating every 10 seconds seems a little slow, maybe something like 3 seconds?

@Pacodastre Pacodastre force-pushed the system-data-tile-on-admin-home-page branch from a8d2b47 to a690099 Compare January 21, 2026 23:46
@Pacodastre
Copy link
Contributor Author

Fixed in the last commit

@DecDuck DecDuck merged commit d8db5b5 into Drop-OSS:develop Jan 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants