Skip to content

Fixing uniqueness performance #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tayjohno merged 1 commit into from
Oct 7, 2025
Merged

Fixing uniqueness performance #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 56 additions & 41 deletions dist/much-select-elm-debug.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12802,68 +12802,83 @@ var $author$project$OptionList$removeEmptyOptions = function (optionList) {
A2($elm$core$Basics$composeR, $author$project$Option$isEmpty, $elm$core$Basics$not),
optionList);
};
var $elm$core$List$member = F2(
function (x, xs) {
return A2(
$elm$core$List$any,
function (a) {
return _Utils_eq(a, x);
},
xs);
var $elm$core$Set$Set_elm_builtin = function (a) {
return {$: 'Set_elm_builtin', a: a};
};
var $elm$core$Set$empty = $elm$core$Set$Set_elm_builtin($elm$core$Dict$empty);
var $elm$core$Set$insert = F2(
function (key, _v0) {
var dict = _v0.a;
return $elm$core$Set$Set_elm_builtin(
A3($elm$core$Dict$insert, key, _Utils_Tuple0, dict));
});
var $elm_community$list_extra$List$Extra$uniqueHelp = F4(
function (f, existing, remaining, accumulator) {
uniqueHelp:
var $elm$core$Dict$member = F2(
function (key, dict) {
var _v0 = A2($elm$core$Dict$get, key, dict);
if (_v0.$ === 'Just') {
return true;
} else {
return false;
}
});
var $elm$core$Set$member = F2(
function (key, _v0) {
var dict = _v0.a;
return A2($elm$core$Dict$member, key, dict);
});
var $author$project$OptionList$fasterUniqueByHelper = F4(
function (_function, remainingList, acc, seen) {
fasterUniqueByHelper:
while (true) {
if (!remaining.b) {
return $elm$core$List$reverse(accumulator);
if (!remainingList.b) {
return $elm$core$List$reverse(acc);
} else {
var first = remaining.a;
var rest = remaining.b;
var computedFirst = f(first);
if (A2($elm$core$List$member, computedFirst, existing)) {
var $temp$f = f,
$temp$existing = existing,
$temp$remaining = rest,
$temp$accumulator = accumulator;
f = $temp$f;
existing = $temp$existing;
remaining = $temp$remaining;
accumulator = $temp$accumulator;
continue uniqueHelp;
var x = remainingList.a;
var xs = remainingList.b;
var key = _function(x);
if (A2($elm$core$Set$member, key, seen)) {
var $temp$function = _function,
$temp$remainingList = xs,
$temp$acc = acc,
$temp$seen = seen;
_function = $temp$function;
remainingList = $temp$remainingList;
acc = $temp$acc;
seen = $temp$seen;
continue fasterUniqueByHelper;
} else {
var $temp$f = f,
$temp$existing = A2($elm$core$List$cons, computedFirst, existing),
$temp$remaining = rest,
$temp$accumulator = A2($elm$core$List$cons, first, accumulator);
f = $temp$f;
existing = $temp$existing;
remaining = $temp$remaining;
accumulator = $temp$accumulator;
continue uniqueHelp;
var $temp$function = _function,
$temp$remainingList = xs,
$temp$acc = A2($elm$core$List$cons, x, acc),
$temp$seen = A2($elm$core$Set$insert, key, seen);
_function = $temp$function;
remainingList = $temp$remainingList;
acc = $temp$acc;
seen = $temp$seen;
continue fasterUniqueByHelper;
}
}
}
});
var $elm_community$list_extra$List$Extra$uniqueBy = F2(
function (f, list) {
return A4($elm_community$list_extra$List$Extra$uniqueHelp, f, _List_Nil, list, _List_Nil);
var $author$project$OptionList$fasterUniqueBy = F2(
function (_function, list) {
return A4($author$project$OptionList$fasterUniqueByHelper, _function, list, _List_Nil, $elm$core$Set$empty);
});
var $author$project$OptionList$uniqueBy = F2(
function (_function, optionList) {
switch (optionList.$) {
case 'FancyOptionList':
var options = optionList.a;
return $author$project$OptionList$FancyOptionList(
A2($elm_community$list_extra$List$Extra$uniqueBy, _function, options));
A2($author$project$OptionList$fasterUniqueBy, _function, options));
case 'DatalistOptionList':
var options = optionList.a;
return $author$project$OptionList$DatalistOptionList(
A2($elm_community$list_extra$List$Extra$uniqueBy, _function, options));
A2($author$project$OptionList$fasterUniqueBy, _function, options));
default:
var options = optionList.a;
return $author$project$OptionList$SlottedOptionList(
A2($elm_community$list_extra$List$Extra$uniqueBy, _function, options));
A2($author$project$OptionList$fasterUniqueBy, _function, options));
}
});
var $author$project$OptionList$organizeNewDatalistOptions = function (optionList) {
Expand Down
236 changes: 195 additions & 41 deletions dist/much-select-elm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7444,68 +7444,222 @@ var $author$project$OptionList$removeEmptyOptions = function (optionList) {
A2($elm$core$Basics$composeR, $author$project$Option$isEmpty, $elm$core$Basics$not),
optionList);
};
var $elm$core$List$member = F2(
function (x, xs) {
return A2(
$elm$core$List$any,
function (a) {
return _Utils_eq(a, x);
},
xs);
var $elm$core$Set$Set_elm_builtin = $elm$core$Basics$identity;
var $elm$core$Dict$RBEmpty_elm_builtin = {$: -2};
var $elm$core$Dict$empty = $elm$core$Dict$RBEmpty_elm_builtin;
var $elm$core$Set$empty = $elm$core$Dict$empty;
var $elm$core$Dict$Black = 1;
var $elm$core$Dict$RBNode_elm_builtin = F5(
function (a, b, c, d, e) {
return {$: -1, a: a, b: b, c: c, d: d, e: e};
});
var $elm$core$Dict$Red = 0;
var $elm$core$Dict$balance = F5(
function (color, key, value, left, right) {
if ((right.$ === -1) && (!right.a)) {
var _v1 = right.a;
var rK = right.b;
var rV = right.c;
var rLeft = right.d;
var rRight = right.e;
if ((left.$ === -1) && (!left.a)) {
var _v3 = left.a;
var lK = left.b;
var lV = left.c;
var lLeft = left.d;
var lRight = left.e;
return A5(
$elm$core$Dict$RBNode_elm_builtin,
0,
key,
value,
A5($elm$core$Dict$RBNode_elm_builtin, 1, lK, lV, lLeft, lRight),
A5($elm$core$Dict$RBNode_elm_builtin, 1, rK, rV, rLeft, rRight));
} else {
return A5(
$elm$core$Dict$RBNode_elm_builtin,
color,
rK,
rV,
A5($elm$core$Dict$RBNode_elm_builtin, 0, key, value, left, rLeft),
rRight);
}
} else {
if ((((left.$ === -1) && (!left.a)) && (left.d.$ === -1)) && (!left.d.a)) {
var _v5 = left.a;
var lK = left.b;
var lV = left.c;
var _v6 = left.d;
var _v7 = _v6.a;
var llK = _v6.b;
var llV = _v6.c;
var llLeft = _v6.d;
var llRight = _v6.e;
var lRight = left.e;
return A5(
$elm$core$Dict$RBNode_elm_builtin,
0,
lK,
lV,
A5($elm$core$Dict$RBNode_elm_builtin, 1, llK, llV, llLeft, llRight),
A5($elm$core$Dict$RBNode_elm_builtin, 1, key, value, lRight, right));
} else {
return A5($elm$core$Dict$RBNode_elm_builtin, color, key, value, left, right);
}
}
});
var $elm_community$list_extra$List$Extra$uniqueHelp = F4(
function (f, existing, remaining, accumulator) {
uniqueHelp:
var $elm$core$Basics$compare = _Utils_compare;
var $elm$core$Dict$insertHelp = F3(
function (key, value, dict) {
if (dict.$ === -2) {
return A5($elm$core$Dict$RBNode_elm_builtin, 0, key, value, $elm$core$Dict$RBEmpty_elm_builtin, $elm$core$Dict$RBEmpty_elm_builtin);
} else {
var nColor = dict.a;
var nKey = dict.b;
var nValue = dict.c;
var nLeft = dict.d;
var nRight = dict.e;
var _v1 = A2($elm$core$Basics$compare, key, nKey);
switch (_v1) {
case 0:
return A5(
$elm$core$Dict$balance,
nColor,
nKey,
nValue,
A3($elm$core$Dict$insertHelp, key, value, nLeft),
nRight);
case 1:
return A5($elm$core$Dict$RBNode_elm_builtin, nColor, nKey, value, nLeft, nRight);
default:
return A5(
$elm$core$Dict$balance,
nColor,
nKey,
nValue,
nLeft,
A3($elm$core$Dict$insertHelp, key, value, nRight));
}
}
});
var $elm$core$Dict$insert = F3(
function (key, value, dict) {
var _v0 = A3($elm$core$Dict$insertHelp, key, value, dict);
if ((_v0.$ === -1) && (!_v0.a)) {
var _v1 = _v0.a;
var k = _v0.b;
var v = _v0.c;
var l = _v0.d;
var r = _v0.e;
return A5($elm$core$Dict$RBNode_elm_builtin, 1, k, v, l, r);
} else {
var x = _v0;
return x;
}
});
var $elm$core$Set$insert = F2(
function (key, _v0) {
var dict = _v0;
return A3($elm$core$Dict$insert, key, 0, dict);
});
var $elm$core$Dict$get = F2(
function (targetKey, dict) {
get:
while (true) {
if (!remaining.b) {
return $elm$core$List$reverse(accumulator);
if (dict.$ === -2) {
return $elm$core$Maybe$Nothing;
} else {
var first = remaining.a;
var rest = remaining.b;
var computedFirst = f(first);
if (A2($elm$core$List$member, computedFirst, existing)) {
var $temp$f = f,
$temp$existing = existing,
$temp$remaining = rest,
$temp$accumulator = accumulator;
f = $temp$f;
existing = $temp$existing;
remaining = $temp$remaining;
accumulator = $temp$accumulator;
continue uniqueHelp;
var key = dict.b;
var value = dict.c;
var left = dict.d;
var right = dict.e;
var _v1 = A2($elm$core$Basics$compare, targetKey, key);
switch (_v1) {
case 0:
var $temp$targetKey = targetKey,
$temp$dict = left;
targetKey = $temp$targetKey;
dict = $temp$dict;
continue get;
case 1:
return $elm$core$Maybe$Just(value);
default:
var $temp$targetKey = targetKey,
$temp$dict = right;
targetKey = $temp$targetKey;
dict = $temp$dict;
continue get;
}
}
}
});
var $elm$core$Dict$member = F2(
function (key, dict) {
var _v0 = A2($elm$core$Dict$get, key, dict);
if (!_v0.$) {
return true;
} else {
return false;
}
});
var $elm$core$Set$member = F2(
function (key, _v0) {
var dict = _v0;
return A2($elm$core$Dict$member, key, dict);
});
var $author$project$OptionList$fasterUniqueByHelper = F4(
function (_function, remainingList, acc, seen) {
fasterUniqueByHelper:
while (true) {
if (!remainingList.b) {
return $elm$core$List$reverse(acc);
} else {
var x = remainingList.a;
var xs = remainingList.b;
var key = _function(x);
if (A2($elm$core$Set$member, key, seen)) {
var $temp$function = _function,
$temp$remainingList = xs,
$temp$acc = acc,
$temp$seen = seen;
_function = $temp$function;
remainingList = $temp$remainingList;
acc = $temp$acc;
seen = $temp$seen;
continue fasterUniqueByHelper;
} else {
var $temp$f = f,
$temp$existing = A2($elm$core$List$cons, computedFirst, existing),
$temp$remaining = rest,
$temp$accumulator = A2($elm$core$List$cons, first, accumulator);
f = $temp$f;
existing = $temp$existing;
remaining = $temp$remaining;
accumulator = $temp$accumulator;
continue uniqueHelp;
var $temp$function = _function,
$temp$remainingList = xs,
$temp$acc = A2($elm$core$List$cons, x, acc),
$temp$seen = A2($elm$core$Set$insert, key, seen);
_function = $temp$function;
remainingList = $temp$remainingList;
acc = $temp$acc;
seen = $temp$seen;
continue fasterUniqueByHelper;
}
}
}
});
var $elm_community$list_extra$List$Extra$uniqueBy = F2(
function (f, list) {
return A4($elm_community$list_extra$List$Extra$uniqueHelp, f, _List_Nil, list, _List_Nil);
var $author$project$OptionList$fasterUniqueBy = F2(
function (_function, list) {
return A4($author$project$OptionList$fasterUniqueByHelper, _function, list, _List_Nil, $elm$core$Set$empty);
});
var $author$project$OptionList$uniqueBy = F2(
function (_function, optionList) {
switch (optionList.$) {
case 0:
var options = optionList.a;
return $author$project$OptionList$FancyOptionList(
A2($elm_community$list_extra$List$Extra$uniqueBy, _function, options));
A2($author$project$OptionList$fasterUniqueBy, _function, options));
case 1:
var options = optionList.a;
return $author$project$OptionList$DatalistOptionList(
A2($elm_community$list_extra$List$Extra$uniqueBy, _function, options));
A2($author$project$OptionList$fasterUniqueBy, _function, options));
default:
var options = optionList.a;
return $author$project$OptionList$SlottedOptionList(
A2($elm_community$list_extra$List$Extra$uniqueBy, _function, options));
A2($author$project$OptionList$fasterUniqueBy, _function, options));
}
});
var $author$project$OptionList$organizeNewDatalistOptions = function (optionList) {
Expand Down
Loading