Skip to content

Don't render headers when all children selected #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sbone wants to merge 2 commits into from
Closed

Don't render headers when all children selected #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3aeaff
Don't render headers when all children selected
sbone Sep 26, 2025
1078a10
Tidy up tests
sbone Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 43 additions & 32 deletions src/GroupedDropdownOptions.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,39 +63,50 @@ optionGroupsToHtml dropdownItemEventListeners selectionConfig groupedDropdownOpt
optionGroupToHtml : DropdownItemEventListeners msg -> SelectionConfig -> DropdownOptionsGroup -> List (Html msg)
optionGroupToHtml dropdownItemEventListeners selectionMode dropdownOptionsGroup =
let
optionGroupHtml =
case dropdownOptionsGroup |> getOptions |> DropdownOptions.maybeFirstOptionSearchFilter of
Just optionSearchFilter ->
case dropdownOptionsGroup |> getOptionsGroup |> OptionGroup.toString of
"" ->
text ""

_ ->
div
[ class "optgroup"
, Html.Attributes.attribute "part" "dropdown-optgroup"
]
[ span [ class "optgroup-header" ]
(tokensToHtml optionSearchFilter.groupTokens)
]

Nothing ->
case dropdownOptionsGroup |> getOptionsGroup |> OptionGroup.toString of
"" ->
text ""

optionGroupAsString ->
div
[ class "optgroup"
, Html.Attributes.attribute "part" "dropdown-optgroup"
]
[ span [ class "optgroup-header" ]
[ text
optionGroupAsString
]
]
options =
getOptions dropdownOptionsGroup

optionsHtml =
optionsToCustomHtml dropdownItemEventListeners selectionMode options
in
optionGroupHtml :: optionsToCustomHtml dropdownItemEventListeners selectionMode (getOptions dropdownOptionsGroup)
if DropdownOptions.isEmpty options then
[]

else
let
optionGroupHtml =
case options |> DropdownOptions.maybeFirstOptionSearchFilter of
Just optionSearchFilter ->
case dropdownOptionsGroup |> getOptionsGroup |> OptionGroup.toString of
"" ->
text ""

_ ->
div
[ class "optgroup"
, Html.Attributes.attribute "part" "dropdown-optgroup"
]
[ span [ class "optgroup-header" ]
(tokensToHtml optionSearchFilter.groupTokens)
]

Nothing ->
case dropdownOptionsGroup |> getOptionsGroup |> OptionGroup.toString of
"" ->
text ""

optionGroupAsString ->
div
[ class "optgroup"
, Html.Attributes.attribute "part" "dropdown-optgroup"
]
[ span [ class "optgroup-header" ]
[ text
optionGroupAsString
]
]
in
optionGroupHtml :: optionsHtml


dropdownOptionsToDatalistHtml : DropdownOptions -> Html msg
Expand Down
64 changes: 63 additions & 1 deletion tests/Option/OrderingInGroups.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
module Option.OrderingInGroups exposing (suite)

import DropdownItemEventListeners exposing (DropdownItemEventListeners)
import DropdownOptions
import Expect
import GroupedDropdownOptions
import Option exposing (Option(..), setGroupWithString, test_newFancyOptionWithMaybeCleanString)
import Html exposing (Html)
import Option exposing (Option(..), newSelectedOption, setGroupWithString, test_newFancyOptionWithMaybeCleanString)
import OptionGroup exposing (OptionGroup)
import OptionList
import OptionValue
import SelectionMode exposing (defaultSelectionConfig)
import Test exposing (Test, describe, test)


Expand Down Expand Up @@ -67,6 +71,20 @@ optionGroupToDebuggingString optionGroup =
OptionGroup.toString optionGroup



-- Mock event listeners for testing HTML rendering


mockEventListeners : DropdownItemEventListeners String
mockEventListeners =
{ mouseOverMsgConstructor = \_ -> "mouseOver"
, mouseOutMsgConstructor = \_ -> "mouseOut"
, mouseDownMsgConstructor = \_ -> "mouseDown"
, mouseUpMsgConstructor = \_ -> "mouseUp"
, noOpMsgConstructor = "noOp"
}


suite : Test
suite =
describe "When we have a sorted list of options"
Expand All @@ -90,4 +108,48 @@ suite =
)
)
)
, test "hide optgroup headers when all options in the group are selected" <|
\_ ->
let
selectedScrewDriver =
newSelectedOption 0 "Screw Driver" Nothing |> setGroupWithString "Hand Tool"

selectedWrench =
newSelectedOption 1 "Wrench" Nothing |> setGroupWithString "Hand Tool"

selectedHammer =
newSelectedOption 2 "Hammer" Nothing |> setGroupWithString "Hand Tool"

selectedChisel =
newSelectedOption 3 "Chisel" Nothing |> setGroupWithString "Hand Tool"

unselectedDrill =
drill

unselectedSawZaw =
sawZaw

allOptions =
OptionList.FancyOptionList
[ selectedScrewDriver
, unselectedDrill
, selectedWrench
, unselectedSawZaw
, selectedHammer
, selectedChisel
]

unselectedOnlyOptions =
DropdownOptions.figureOutWhichOptionsToShowInTheDropdownThatAreNotSelected
defaultSelectionConfig
allOptions

renderedHtml =
GroupedDropdownOptions.groupOptionsInOrder unselectedOnlyOptions
|> GroupedDropdownOptions.optionGroupsToHtml mockEventListeners defaultSelectionConfig

elementCount =
List.length renderedHtml
in
Expect.equal 3 elementCount
]