-
Notifications
You must be signed in to change notification settings - Fork 9
#2 again: Cannot read property of _value of undefined #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
just saw that #5 is doing some form of file renaming manipulation, looks like a better approach than this one |
| // ConcatenatedModule | ||
| // ExternalModule | ||
| // ContextModule | ||
| if (mod._source === null) return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just keep this fix in this PR, and then I'll merge #5 (want to make sure @bv-loveholidays gets credit for doing that part)? Then I can merge + release both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done! 💃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh oops, I don't know how I missed this.
|
Thanks @claudiordgz! Appreciate the PR. Just that one comment 😃 |
|
so, is this ready to mrege? |
Hi all,
I'm compiling a TypeScript library to be used on Node Applications (Lambdas). I tried using this plugin but couldn't get past the
cannot read property of _value of undefinedproblem.Turns out
_sourcecomes null for more thanMultiModule. The first one I found wasConcatenatedModule.I kept digging and found that
_sourcealso comes null for everyone on this list (but not limited to tho):I tried just doing
if (mod._source === null) return;with great success, all my TS code appeared in a single folder as javascript, but with the.tsfile extension.So I added the following to handle this:
This might not be desired/wanted I just did it because it was pretty simple, so no hard feelings if it's a non-issue and you close it.