Skip to content
This repository was archived by the owner on Jan 4, 2022. It is now read-only.

rounding errors cause empty white space#55

Open
Kajakske wants to merge 1 commit intoDrewDahlman:masterfrom
Kajakske:master
Open

rounding errors cause empty white space#55
Kajakske wants to merge 1 commit intoDrewDahlman:masterfrom
Kajakske:master

Conversation

@Kajakske
Copy link

If the total available size is not dividable between the desired amount of columns, you possibly get empty space.
Example:
Available width: 20px
Desired cols: 3.

Each col width: 6.66px, current code rounds it to 7px.
7px x 3 cols cuases the last block to jump to a new line.
Flooring the width results in 3 x 6px cols.

Ideally, it should create blocks 6, 6 & 7px wide, however, my fix is easy and results in only 2 empty pixels on the right and 3 cols as desired.

If the total available size is not dividable between the desired amount of columns, you possibly get empty space.
Example: 
Available width: 20px
Desired cols: 3.

Each col width: 6.66px, current code rounds it to 7px.
7px x 3 cols cuases the last block to jump to a new line.
Flooring the width results in 3 x 6px cols.
@laurensV
Copy link

laurensV commented Mar 7, 2017

This problem still exists (off by one pixel due to rounding issues).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants