This repository was archived by the owner on Jan 4, 2022. It is now read-only.
rounding errors cause empty white space#55
Open
Kajakske wants to merge 1 commit intoDrewDahlman:masterfrom
Open
rounding errors cause empty white space#55Kajakske wants to merge 1 commit intoDrewDahlman:masterfrom
Kajakske wants to merge 1 commit intoDrewDahlman:masterfrom
Conversation
If the total available size is not dividable between the desired amount of columns, you possibly get empty space. Example: Available width: 20px Desired cols: 3. Each col width: 6.66px, current code rounds it to 7px. 7px x 3 cols cuases the last block to jump to a new line. Flooring the width results in 3 x 6px cols.
|
This problem still exists (off by one pixel due to rounding issues). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the total available size is not dividable between the desired amount of columns, you possibly get empty space.
Example:
Available width: 20px
Desired cols: 3.
Each col width: 6.66px, current code rounds it to 7px.
7px x 3 cols cuases the last block to jump to a new line.
Flooring the width results in 3 x 6px cols.
Ideally, it should create blocks 6, 6 & 7px wide, however, my fix is easy and results in only 2 empty pixels on the right and 3 cols as desired.