handle gemius codes #63
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for handling Gemius codes by integrating a new script URL into the native ad response. The changes include:
- Adding constants for the Gemius script URL, parameter prefix, and required parameters.
- Extending the native response with a new JavaScript tracker that injects the Gemius script.
- Adding a helper function (getGdeScriptUrl) that constructs the Gemius script URL based on ad data fields.
| if (REQUIRED_GDE_PARAMS.every(param => adDataFields[param])) { | ||
| const params = new URLSearchParams(); | ||
| Object.entries(adDataFields) | ||
| .filter(([key]) => key.startsWith(GDE_PARAM_PREFIX)) |
There was a problem hiding this comment.
Consider ensuring that only the required parameters (those in REQUIRED_GDE_PARAMS) are included in the URL query string to avoid unintentionally appending extra fields from adDataFields.
| .filter(([key]) => key.startsWith(GDE_PARAM_PREFIX)) | |
| .filter(([key]) => REQUIRED_GDE_PARAMS.includes(key) && key.startsWith(GDE_PARAM_PREFIX)) |
| return nativeResponse | ||
| } | ||
|
|
||
| const getGdeScriptUrl = (adDataFields) => { |
There was a problem hiding this comment.
[nitpick] Add inline comments to clarify the expected structure of adDataFields and the purpose of each key in REQUIRED_GDE_PARAMS to assist future maintainers.
kpiegza
left a comment
kpiegza
left a comment
There was a problem hiding this comment.
Spoko, wszystko gra. Myślałem nad jakimś cache busterem, ale ten skrypt i tak raczej będzie rzadko wdrażany, a że pola z kreacji lecą w query paramsach, to w sumie trochę będzie działać jak cache buster, więc chyba nie ma sensu kombinować.
No description provided.