Conversation
It turns out that compilers require movability for arguments passed by value (checked three majors in godbolt with cppcoro). Hence, if allocator is non-movable but copyable, it makes no sense for the `new`/`delete` - the coroutine itself won't compile. I decieded to make `new` accept any `Alloc` that satisfies `CoroutineAllocator` concept just to make sure we receive no matter what type of allocator value/reference - we will copy it anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that compilers require movability for arguments passed by value (checked three majors in godbolt with cppcoro). Hence, if allocator is non-movable but copyable, it makes no sense for the
new/delete- the coroutine itself won't compile. I decided to makenewaccept anyAllocthat satisfiesCoroutineAllocatorconcept just to make sure we receive no matter what type of allocator value/reference - we will copy it anyway.