Open
Conversation
Owner
|
Hey, thanks for the PR! Code seems fine, but rustfmt is unhappy. Would you mind to fix this, then I can include this feature in the next release. :) |
haileys
force-pushed
the
optional-time
branch
from
1574e60 to
08b7a80
Compare
Author
|
Thanks for such a quick reply!! I've force pushed a new commit |
Owner
|
Now one of the tests doing the "test"-feature in isolation is unfortunately unhappy. 😬 I would also appreciate it, if you could adjust the ci.yml to run a new test for the feature you introduced in isolation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.