use partial ticks for smooth enchanted item rotations#381
Open
BMasta wants to merge 1 commit intoDragonsPlusMinecraft:1.21.1/6.0.0-devfrom
Open
use partial ticks for smooth enchanted item rotations#381BMasta wants to merge 1 commit intoDragonsPlusMinecraft:1.21.1/6.0.0-devfrom
BMasta wants to merge 1 commit intoDragonsPlusMinecraft:1.21.1/6.0.0-devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that animations for items above the blaze forger and blaze enchanter are choppy. Upon inspecting the code I found that
xRotandzRotin blaze renderers do not use partial ticks.This PR fixes the problem by adding partial ticks to
renderTicks.Tested in game and the animations are now smooth. Tried capturing on video, but it's a little hard to see at 30fps.