TypeScript type definitions #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might still be quite broken
Instead of importing * as preact, index.d.ts now just imports preact.
Author
|
I've just noticed that this is incompatible with Preact X. To make it work, |
Owner
|
I think there is probably some small issue with the tests, because they worked when I last looked at this. Please become a maintainer, then you can merge it yourself :) Join the discussion at #34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an
index.d.tsfile that contains type definitions (as requested by @sammkj in #28).I have to admit that I didn't really check that everything is correct. Still, this is just a port of
@types/react-helmetv4, so, as long as this is a port ofreact-helmetv4, they should be correct.Maybe the file should be put inside
src, and the scripts should be changed to copy the file at build time? I've seen that many repos have it in the root directory though.(this is my first pull request I sincerely hope I haven't messed anything up)
Edit: closes #32.