-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/#14/notice 기능 개발 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jwooo002
wants to merge
10
commits into
develop
Choose a base branch
from
feat/#14/notice-기능-개발
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
The head ref may contain hidden characters: "feat/#14/notice-\uAE30\uB2A5-\uAC1C\uBC1C"
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
KoungQ
reviewed
Sep 9, 2025
| return BaseResponse.onSuccess(loadNoticesUseCase.loadNotices(userNo, roomNo)); | ||
| } | ||
|
|
||
| @GetMapping("/api/notice") |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/api/notices/{noticeNo}
|
|
||
| private final DeleteNoticeUseCase deleteNoticeUseCase; | ||
|
|
||
| @DeleteMapping("/api/notice") |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/api/notices/{noticeNo}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Template
📌 제목
notice 도메인 개발
📢 요약
글 작성, 글 수정, 글 상세 조회, 글 목록 조회, 글 삭제 구현
🔗 연관 이슈: Resolves #이슈번호
#14
#15
🚀 PR 유형
✅ PR 체크리스트
📜 기타
삭제할 때 소프트 삭제를 해야하나 하드 삭제를 해야하나 잘 모르겠네요 테이블 별로 다를 거 같긴 한데
지금까지 제가 개발한 도메인에 있는 테이블들은 모두 하드 삭제 했어요