Open
Conversation
github-actions
bot
added
Sprites
00-Steven
requested changes
Mar 22, 2026
Collaborator
00-Steven
left a comment
00-Steven
left a comment
There was a problem hiding this comment.
lot of comments on the code for this, starting with a few today, gotta do more later
Comment on lines
+151
to
+162
| /obj/structure/signboard/holosign/proc/set_color(new_color) | ||
| new_color = sanitize_color(new_color) | ||
| if(!new_color) | ||
| testing("signboard color invalid or null, removing") | ||
| current_color = null | ||
| remove_atom_colour(FIXED_COLOUR_PRIORITY) | ||
| else | ||
| testing("signboard color valid, adding") | ||
| current_color = new_color | ||
| add_atom_colour(new_color, FIXED_COLOUR_PRIORITY) | ||
| set_light(l_color = current_color || src::light_color) | ||
| update_appearance() |
Collaborator
There was a problem hiding this comment.
why recolor the whole thing? it looks weird when the stand also gets colored
why not split the dmi into the a greyscale of the colored parts and the stand/background, and adding the first as a recolored overlay?
| /// The current text written on the sign. | ||
| var/sign_text | ||
| /// The maximum length of text that can be input onto the sign. | ||
| var/max_length = MAX_PLAQUE_LEN |
Collaborator
There was a problem hiding this comment.
what does max length actually look like on this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Port of Monkestation/OculisStation#66
This adds signboards! Player-craftable signs, that display maptext above them. Easily craftable. Also fully logged, so admins can easily see who edited what sign when.
There's normal wooden signs - just need 5 wood planks, but they need a pen to write/clear, and their color can't be changed. Then there's holographic signs - you can change their color, you don't need a pen, and you can lock them to an ID so only you can edit it (note: the lock can be permanently broken with an emag)
They also respect the server's configured IC chat filters.
Why it's Good for the Game
Fun ways for players to do gimmicks and creative stuff are always nice!
Testing Evidence
Changelog
🆑 Absolucy, ancient-engineer
add: Added signboards, player craftable signs that display text above them in the world that everyone can see!
add: Wooden signboards can be crafted with 5 wooden planks, but need a pen to edit/clear.
add: Holographic signboards can be crafted with 5 iron, 5 cables, and 1 micro-laser, and can change color, alongside allowing you to lock it to your ID, so that only you can edit or clear it. An emag will permanently break the lock, tho!
image: Signboard sprites by ancient-engineer.
admin: Admins can see logs about signboard edits/changes via the "Signboards" investigate log category.
/:cl: