fix: Improve startPosition support in players#894
Merged
PartyDonut merged 2 commits intoDonutWare:developfrom Apr 4, 2026
Merged
fix: Improve startPosition support in players#894PartyDonut merged 2 commits intoDonutWare:developfrom
PartyDonut merged 2 commits intoDonutWare:developfrom
Conversation
ddd79e6 to
d1bf570
Compare
PartyDonut
approved these changes
Apr 4, 2026
Collaborator
PartyDonut
left a comment
There was a problem hiding this comment.
Looks good to me, I combined the same calls into a new function but everything else seems good thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request introduces consistent support for starting video playback from a specified position across the entire playback stack. The changes ensure that the
startPositionparameter is correctly propagated and respected by all player implementations and playback helpers. Additionally, the logic for determining the initial playback position has been improved, defaulting to a saved or provided position as appropriate.Playback start position propagation and handling:
BasePlayer,LibMDK,LibMPV,NativePlayer, and their web stubs) now accept an optionalstartPositionparameter in theloadVideomethod, ensuring that playback can start from the correct position across all platforms.MediaControlsWrapperandVideoPlayerNotifierclasses have been updated to pass thestartPositionto the player and to handle playback state updates accordingly, including callingplaybackStartedwhen playback begins.Improved logic for determining playback start position:
startPosition, a saved resume position, or zero if none are available).These changes collectively ensure a more robust and user-friendly resume playback experience, with consistent handling of playback positions throughout the codebase.
Just as a disclaimer I did use Antigravity Agent to create this PR, so if you think somethings don't make sense or the PR looks more like a workaround rather than a fix let me know.
Issue Being Fixed
Solves 2 issues:
Resolves #770, #565
Screenshots / Recordings
Checklist