Replace StandardRB with RuboCop and configure for double-quoted strings #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove standard gem and add rubocop gem to Gemfile - Create comprehensive .rubocop.yml configuration with: - Double-quoted strings (EnforcedStyle: double_quotes) - Relaxed RSpec cops for integration tests (Max 5 expectations, 10 lines) - Disabled IndexedLet cop (mod1, mod2 are clear in test context) - Reasonable metrics thresholds (AbcSize: 35, MethodLength: 20) - Disabled ActiveRecord-specific cops (we use Firestore) - Update bin/audit to use 'rubocop --parallel' instead of standardrb - Remove .standard.yml and .standard_rubocop_extensions.yml - Auto-correct 1049+ style violations across 63 files - Rename spec/helpers/mods_helper_spec.rb → mod_helper_spec.rb - Fix test failures from RuboCop's ActiveRecord optimizations All audits passing: - bundle-audit: No vulnerabilities - brakeman: No security warnings - rubocop: 63 files inspected, no offenses detected - rspec: 222 examples, 0 failures Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dyoung522
had a problem deploying
to
workflow-test
GitHub Actions
Failure
There was a problem hiding this comment.
Pull request overview
This PR replaces StandardRB with RuboCop to allow for customized linting rules and double-quoted string preference. The configuration is comprehensive and appropriate for a Rails application using Firestore instead of ActiveRecord.
Changes:
- Removed StandardRB gem and configuration files, added RuboCop with plugins for Rails, RSpec, and performance
- Created
.rubocop.ymlwith sensible defaults including double-quoted strings, relaxed RSpec cops, and disabled ActiveRecord-specific cops - Auto-corrected 1049+ style violations across spec files and application code including frozen string literals, block syntax, hash spacing, and indentation
Reviewed changes
Copilot reviewed 26 out of 29 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .rubocop.yml | New RuboCop configuration with Rails and RSpec-friendly settings |
| Gemfile | Removed standard gem, added rubocop and related plugins |
| Gemfile.lock | Updated dependencies, including rubocop-rspec v2→v3 upgrade |
| bin/audit | Updated to run rubocop --parallel instead of standardrb |
| .standard.yml, .standard_rubocop_extensions.yml | Removed StandardRB config files |
| .claude/settings.local.json | Added Claude Code permissions (contains outdated standardrb reference) |
| Rakefile, Guardfile | Added frozen_string_literal comments |
| Gemfile | Added frozen_string_literal comment |
| spec/**/* | Auto-corrected: frozen_string_literal, block syntax (do/end), hash spacing, expect blocks |
| app/models/*.rb | Auto-corrected: line breaking for long constants, rescue clause formatting |
| app/controllers/*.rb | Auto-corrected: hash spacing, line breaking, empty method syntax |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.claude/settings.local.json
Outdated
| "Bash(then bin/spring stop)", | ||
| "Bash(else echo \"No Spring\")", | ||
| "Bash(fi)", | ||
| "Bash(bundle exec standardrb:*)", |
There was a problem hiding this comment.
This permissions entry still references StandardRB, which has been replaced with RuboCop in this PR. Since StandardRB is no longer used, this permission should be removed to keep the configuration consistent.
Suggested change
| "Bash(bundle exec standardrb:*)", |
dyoung522
temporarily deployed
to
workflow-test
GitHub Actions
Inactive
The .claude/ directory contains user-specific Claude Code settings (permission allowlists, etc.) and should not be version controlled. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dyoung522
temporarily deployed
to
workflow-test
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 28 out of 32 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaced StandardRB with RuboCop using a sensible configuration that prefers double-quoted strings and includes reasonable thresholds for Rails applications.
Changes
rubocopgem.rubocop.ymlwith:EnforcedStyle: double_quotes)RSpec/IndexedLet(variables likemod1,mod2are clear in test context)Rails/FindEach,Rails/RedundantActiveRecordAllMethod)bin/auditto runrubocop --parallelinstead ofstandardrb.standard.ymland.standard_rubocop_extensions.ymlspec/helpers/mods_helper_spec.rb→spec/helpers/mod_helper_spec.rbto match helper nameVerification
All audits and tests passing:
Why This Change?
StandardRB is intentionally opinionated and doesn't allow customization of cop thresholds, which made it incompatible with our testing patterns (integration tests naturally have multiple expectations) and string literal preferences (double quotes). RuboCop provides the flexibility we need while maintaining code quality standards.
🤖 Generated with Claude Code