feat: add info button for scripts permissions page#66
Conversation
| <div class="modal-box max-w-sm"> | ||
| <h2 class="card-title mb-2">Scripts permissions info</h2> | ||
| <p> | ||
| In this page, an admin can modify the editlist (task/automation), whitelist and blacklist (only for tasks). |
There was a problem hiding this comment.
I won't say "an admin", we can just say "you" as there can be only one admin and he's the only one able to see this page
| In this page, an admin can modify the editlist (task/automation), whitelist and blacklist (only for tasks). | ||
| </p> | ||
| <p> | ||
| The admins are not showed in these lists since they already have every permission to modify and execute every task and automation. |
There was a problem hiding this comment.
Here we can say "you", instead of "the admins" for the same reasons stated before
| </li> | ||
| <li> | ||
| <span class="font-bold">Whitelist</span>: a whitelisted user can execute the task | ||
| even if he doesn't have the permissions for executing devices inside it. |
There was a problem hiding this comment.
I would refer to user-device permissions as "for executing devices" is not so clear
| </li> | ||
| <li> | ||
| <span class="font-bold">Blacklist</span>: a blacklisted user can't execute the task | ||
| even if he has the permissions for executing devices inside it. |
There was a problem hiding this comment.
"for executing devices" same as before
Ventus218
left a comment
Ventus218
left a comment
There was a problem hiding this comment.
About your question I'd say is a good idea to also add a description to user-device permissions page
|
I'd put the info button and dialog in the page where the admin can see all the tasks/automations and not where they manage the permissions of a single script, if you want to do so I'd say split the dialog in two: for tasks just talk about tasks, for automations just talk about automations. |
| </li> | ||
| <li> | ||
| <span class="font-bold">Blacklist</span>: a blacklisted user can't execute the task | ||
| even if he has the permissions for user-device permissions inside it. |
There was a problem hiding this comment.
I'd say "A blacklisted user can't execute the task even if he has all the necessary user-device permissions." And viceversa for the whitelist.
| </p> | ||
| <p> | ||
| By clicking on a user, you are shown a list of device permissions that you can add or remove for the selected user. | ||
| The device permission allows the user to use that device. |
There was a problem hiding this comment.
I'd say "allows the user to execute actions of that device"
| When a user has all the device permissions required by a task, he can execute it. | ||
| </p> | ||
| <p> | ||
| You are not showed in these lists since you already have every permission to execute every device. |
|
🎉 This PR is included in version 0.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
Tell me if you like also to add this button on the tasks and automations permissions page, where there are the tasks and automations lists.