Add Zenara Health Domain Connect mail templates #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linter OK: |
kerolasa
reviewed
Dec 19, 2025
| "serviceId": "whitelabel-custom-mail-alias", | ||
| "serviceName": "White Label - Custom Mail alias", | ||
| "version": 1, | ||
| "logoUrl": "https://zenarahealth.io/assets/zenarahealth.svg", |
Collaborator
There was a problem hiding this comment.
Does this domain work? The zenarahealth.io does not have A or AAAA record, and the www.zenerahealth.io gives certificate error.
| "logoUrl": "https://zenarahealth.io/assets/zenarahealth.svg", | ||
| "description": "Configures your domain to work with Zenara Health's white label service with custom mail address.", | ||
| "variableDescription": "This configuration sets whitelabel for custom domain and email address.", | ||
| "syncPubKeyDomain": "zenarahealth.io", |
Collaborator
There was a problem hiding this comment.
Since you need to look into DNS anyway please have a look the public key TXT record works as expected. There are pretty good instructions in https://exampleservice.domainconnect.org/sig to get the signature sorted.
| { | ||
| "type": "A", | ||
| "host": "%host4%", | ||
| "pointsTo": "%record4%", |
Collaborator
There was a problem hiding this comment.
These templates add quite many records to customer domain. It would be nice to describe what the records are used for in variable description. Or at least in the git commit message. Ideally the pull request description could show how example.com would look like after it would be applied by this template. Try to answer the question: if I as a customer would apply this template to my zone what would I get?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Domain Connect templates for Zenara Health mail services.