fix focus border not appearing on workspace and output panels#9
Merged
fix focus border not appearing on workspace and output panels#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spotted a regression from the OnFocus and OnBlur centralisation work. workspace and output panels weren't showign green borders when focused, while migrations and details worked fine
turned out to be a reference issue.
ApplyFocusStyle()was accessing the view throughself.view(the BaseContext field), but gocui'sSetView()can return a different reference each frame. migrations and details never had this problem because they set colours directly on the localvvariable inDraw(), never going throughself.viewfix is simple. replaced the
ApplyFocusStyle()call with inline colour setting inDraw(), same pattern migrations and details already use. all four panels are consistent nowalso I bumped versino to v0.3.2