refactor panel architecture to context+trait pattern and introduce json based i18n#7
Merged
refactor panel architecture to context+trait pattern and introduce json based i18n#7
Conversation
lazygit style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2
Fairly substantial rework of the internal architecture, along with a proper i18n system.
The old
command.gowas doing far too much, so that's been split out into separate controllers for migrations, generate, studio and clipboard. panel logic new follows a context+trait composition approach underpkg/gui/context. All that duplicated modal code has been pulled into a sharedBaseModal. Colour helpers got their own home inpkg/gui/style, and the core interfaces likeIContextandIKeybindingsnow live inpkg/gui/types.For i18n, translations are loaded from embedded JSON files and merged on top of the English defaults using mergo. It picks up the system locale automatically from LC_ALL, LC_MESSAGES or LANG, and anything missing just falls back to English, German's in there as the first non English language.
Cleaned up some odds and ends as well. Got rid of leftover test utilities and commented out keybindings, fixed a dodgy format argument in the generate failure log, and sorted out a couple of runtime panic risks.