Skip to content

Conversation

@saitho
Copy link

@saitho saitho commented Nov 2, 2017

Adds redeemGameKey functionality described in #7.

Example usage: https://gist.github.com/saitho/a5466402b4bc1c7b2ec431c350f08567

@saitho saitho mentioned this pull request Nov 2, 2017
Copy link

@Revadike Revadike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other styling issues (using spaces, not tabs).

});
};

SteamStore.prototype.redeemGameKey = function(code, callback) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SteamStore.prototype.redeemGameKey = function(code, callback) {
SteamStore.prototype.redeemSteamKey = function(code, callback) {

or simply

Suggested change
SteamStore.prototype.redeemGameKey = function(code, callback) {
SteamStore.prototype.redeemKey = function(code, callback) {

Steam keys don't only activate games, they activate any type of app. Technically, steam keys redeem steam packages.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or "product key" 🤔

Comment on lines +164 to +165
### redeemGameKey(gameKey[, callback])
- `gameKey` - The Steam game key you want to redeem

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### redeemGameKey(gameKey[, callback])
- `gameKey` - The Steam game key you want to redeem
### redeemSteamKey(steamKey[, callback])
- `steamKey` - The Steam activation key you want to redeem

or simply

Suggested change
### redeemGameKey(gameKey[, callback])
- `gameKey` - The Steam game key you want to redeem
### redeemKey(key[, callback])
- `key` - The Steam activation key you want to redeem

Steam keys don't only activate games, they activate any type of app. Technically, steam keys redeem steam packages.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or "product key" 🤔

@Revadike
Copy link

@DoctorMcKay Why wasn't this merged in some way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants