-
Notifications
You must be signed in to change notification settings - Fork 0
Update to Java 25 (LTS) #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update to Java 25 (LTS) #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0477875 to
f385f13
Compare
82da5ce to
1b38a5e
Compare
Since JUnit 6 all Autocloseable values in the extension context are automatically closed, so we don't need to manually close anymore
003b633 to
93e3431
Compare
93e3431 to
9fae88e
Compare
GuusLieben
commented
Dec 24, 2025
| .map(ServiceLoader.Provider::get) | ||
| .collect(Collectors.toSet()); | ||
| Iterator<T> it = serviceLoader.iterator(); | ||
| while (true) { |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #1153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
With the release of Java 25, which is the latest LTS release at the time of writing, Hartshorn will drop Java 21 as its main JDK target. As such, this PR migrates our tooling to Java 25, and fixes minor issues with compact source files (related to constructorless classes in unnamed packages).
A known limitation of compact source files is the fact that they do not reside within a named package. As such, we cannot perform automatic package scanning unless explicitly declared. The main class itself will always be included, including any bindings it declares.
A valid compact source file may look like the sample below, which is adapted from the Java Launchpad sample starter:
Checklist
developbranch