Conversation
1. Удаление пользователей и фильмов; 2. Логирование; 3. Поиск фильмов; 4. Фильтрация популярных фильмов; 5. Рекомендации. Общие фильмы; 6. Режиссёры; 7. Отзывы.
avfyodorov
reviewed
Aug 8, 2023
avfyodorov
left a comment
avfyodorov
left a comment
There was a problem hiding this comment.
Добрый день, Фёдор!
У вас очень хорошая работа. Вы быстро сумели сделать грамотную реализацию задач, с разбивкой по слоям и разделением функционала. А, с учётом того, что команда у вас несыгранная, результат можно считать просто прекрасным. Вам удалось избежать типичных ошибок, возникающих на этом этапе.
От меня только несколько мелких уточнений.
src/main/java/ru/yandex/practicum/filmorate/controller/FilmController.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/yandex/practicum/filmorate/controller/DirectorController.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/yandex/practicum/filmorate/controller/DirectorController.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/yandex/practicum/filmorate/controller/ErrorHandler.java
Show resolved
Hide resolved
src/main/java/ru/yandex/practicum/filmorate/dao/impl/ReviewLikesRepositoryImpl.java
Outdated
Show resolved
Hide resolved
…йс EventService Имплиментация сервисов вынесена в отдельный пакет. Исправлены мелкие недочеты.
avfyodorov
reviewed
Aug 9, 2023
avfyodorov
left a comment
avfyodorov
left a comment
There was a problem hiding this comment.
Добрый день!
Замечаний нет.
Групповой проект принят.
Поздравляю с удачным опытом групповой разработки, успехов!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Команда №8. Тимлид - Чижик Фёдор