Optimizing N163 in NSF driver#400
Merged
Gumball2415 merged 2 commits intoDn-Programming-Core-Management:mainfrom Jan 20, 2026
Merged
Optimizing N163 in NSF driver#400Gumball2415 merged 2 commits intoDn-Programming-Core-Management:mainfrom
Gumball2415 merged 2 commits intoDn-Programming-Core-Management:mainfrom
Conversation
Collaborator
|
changing the target to main branch |
Fixing current driver exceeding a frame to progress
7baa30f to
bca33d9
Compare
Collaborator
|
lgtm, though i'm a bit unsure about the byte order edit in the nsf driver build script |
Contributor
Author
|
I had no way to make it work properly other than adding new arguments there. It simply didn't work with both Python 2 and Python 3 (which is what CONTRIBUTING.md describes) without inserting updated arguments |
Collaborator
|
CONTRIBUTING.md specifically mentions Python 3.10 and above
however, Python docs mentions that the default argument for
|
Contributor
Author
|
Seems like it's CONTRIBUTING.md that should be updated then |
Collaborator
|
changelog:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the current driver with N163 enabled exceeding a frame (single 60Hz tick) by optimizing the waveform copying routine.
Changes in this PR: