HW#2 Khyzhniak #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 86bc786.
Comment on lines
+147
to
+157
| function example1_8_0() { | ||
| var dmytroKhyzhniak; | ||
| let coolDmytroKhyzhniak; | ||
| const dmytroKorol; | ||
| } | ||
|
|
||
| // 1.8.1 In other languages you can see PascalCase, snake_case, kebab-case. | ||
| function example1_8_1() { | ||
| var ThisIsPascalCase; | ||
| let this_is_snake_case; | ||
| } |
There was a problem hiding this comment.
not necessary. primarily depends on the agreements on the project
Comment on lines
+190
to
+198
| // BUILDING STRARTED 🕐 | ||
| let floor1 = 'Floor #1 | □ □ | LET'; | ||
| const floor2 = 'Floor #2 | □ □ | CONST'; | ||
| var floor3 = 'Floor #3 | □ □ | VAR'; | ||
| let floor4 = function() { return 'Floor #4 | □ □ | LET FUNCTION EXPESSION' }; | ||
| const floor5 = function() { return 'Floor #5 | □ □ | CONST FUNCTION EXPESSION' }; | ||
| var floor6 = function() { return 'Floor #6 | □ □ | VAR FUNCTION EXPESSION' }; | ||
| function floor7() { return 'Floor #7 | □ □ | FUNCTION DECLARATION' }; | ||
| // ✅ BUILDING COMPLETED ✅ |
There was a problem hiding this comment.
I got the idea, but it's better to use formatting by the first character in the line)
Comment on lines
+567
to
+587
| let user = { | ||
| name: "Dmytro", | ||
| platform: "PC", | ||
| } | ||
|
|
||
| function setUserToken(user) { | ||
| let todaysToken = '25006eb5cb6b9aa164f8fc50e06546d3'; | ||
|
|
||
| function generateCustomToken() { | ||
| let randomID = Math.round(Math.random() * 1000); | ||
| // TODO: check if ID is free | ||
| let generatedToken = `${randomID}#${todaysToken}`; | ||
| user.token = generatedToken; | ||
|
|
||
| return generatedToken; | ||
| } | ||
|
|
||
| return generateCustomToken(); | ||
| } | ||
|
|
||
| console.log(setUserToken(user)); |
There was a problem hiding this comment.
"default value for a function" - meanы something like
function coolFunc(data = 11) { console.log(data); }
DmitryKorolDevPro
approved these changes
Feb 23, 2021
dmytro-khyzhniak
added a commit
that referenced
this pull request
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HW#2 done.