Skip to content

Update so split function will not return "ends" when passing empty pattern #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DmitryDodzin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update so split function will not return "ends" when passing empty pattern #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/context/builtins.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,16 @@ pub fn capture(input: &Value, re: &Value) -> Result<Value> {
pub fn split(value: &Value, re: &Value) -> Result<Value> {
match (value, re) {
(Value::Null, _) => Ok(Value::Null),

(Value::String(value), Value::String(empty)) if empty.is_empty() => Ok(Value::Array(
value
.split("")
.skip(1) // custom case where the patten is empty to match java behaviour
.take(value.len())
.map(str::to_owned)
.map(Value::String)
.collect(),
)),
(Value::String(value), Value::String(re)) => {
let re = Regex::new(re).map_err(|err| {
JsltError::RuntimeError(format!("Unexpected error when parsing re: {err}"))
Expand Down
2 changes: 1 addition & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,7 @@ mod tests {
#[case("1,2,3,4,5".into(), ";".into(), r#"["1,2,3,4,5"]"#)]
#[case("null", ";".into(), "null")]
#[case(",2".into(), ",".into(), r#"["", "2"]"#)]
// #[case("2,".into(), ",".into(), r#"["2"]"#)] TODO: maybe add the logic
#[case("22".into(), "".into(), r#"["2", "2"]"#)]
fn function_split(
#[case] left: Value,
#[case] right: Value,
Expand Down