Encoding and Encrypting for Elgamal pub-key and AES sym. key#3
Merged
paveltyk merged 12 commits intoDivvyPayHQ:mainfrom Feb 7, 2025
Merged
Encoding and Encrypting for Elgamal pub-key and AES sym. key#3paveltyk merged 12 commits intoDivvyPayHQ:mainfrom
paveltyk merged 12 commits intoDivvyPayHQ:mainfrom
Conversation
paveltyk
force-pushed
the
encrypt-with-elgamal-and-aes
branch
from
4266908 to
ffb51a3
Compare
paveltyk
force-pushed
the
encrypt-with-elgamal-and-aes
branch
from
d53657d to
8cfc665
Compare
paveltyk
force-pushed
the
encrypt-with-elgamal-and-aes
branch
2 times, most recently
from
56c2612 to
f3c8230
Compare
…ket.encrypt/2,3. Added MDC support.
paveltyk
force-pushed
the
encrypt-with-elgamal-and-aes
branch
from
f3c8230 to
3c254ef
Compare
…essionKeyPacket.ecrypt/4. Introduced Util.PKCS1.encode/3
paveltyk
force-pushed
the
encrypt-with-elgamal-and-aes
branch
12 times, most recently
from
05dce31 to
b8be604
Compare
paveltyk
force-pushed
the
encrypt-with-elgamal-and-aes
branch
from
b8be604 to
bdf944a
Compare
lytedev
reviewed
Feb 6, 2025
paveltyk
force-pushed
the
encrypt-with-elgamal-and-aes
branch
from
a05d394 to
bdf944a
Compare
lytedev
reviewed
Feb 6, 2025
lytedev
reviewed
Feb 6, 2025
lytedev
reviewed
Feb 6, 2025
lytedev
requested changes
Feb 6, 2025
lytedev
left a comment
lytedev
left a comment
There was a problem hiding this comment.
A few changes that would be nice to have, but also happy to defer to a point release.
paveltyk
force-pushed
the
encrypt-with-elgamal-and-aes
branch
5 times, most recently
from
2363501 to
8119b57
Compare
paveltyk
force-pushed
the
encrypt-with-elgamal-and-aes
branch
from
8119b57 to
e35e1f1
Compare
lytedev
approved these changes
Feb 7, 2025
nadams
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows encoding and encrypting of:
v0.6.0
Enhancements
OpenPGP.Encodeprotocol with.encode/1,2and.tag/1.OpenPGP.Encodeprotocol implementation for:OpenPGP.PublicKeyEncryptedSessionKeyPacketOpenPGP.IntegrityProtectedDataPacketOpenPGP.LiteralDataPacketOpenPGP.PacketOpenPGP.Packet.PacketTagOpenPGP.Packet.BodyChunkOpenPGP.Encryptprotocol with.encrypt/1,2.OpenPGP.Encryptprotocol implementation for:OpenPGP.PublicKeyEncryptedSessionKeyPacketwith Elgamal (Public-Key algo 16).OpenPGP.IntegrityProtectedDataPacketwith AES-128, AES-192, AES-256 (Sym.algo 7,8,9).OpenPGP.encode_packet/1that delegate toOpenPGP.Encodeprotocol.OpenPGP.encrypt_packet/1that delegate toOpenPGP.Encryptprotocol.OpenPGP.PublicKeyPacket.decode/1.OpenPGP.ModificationDetectionCodePacket.OpenPGP.Util.PKCS1with PKCS#1 block encoding EME-PKCS1-v1_5.OpenPGP.Util.encode_mpi/1and added exception for too long big-endian numbers (>65535 octets).