Improve ppcomp#1743
Merged
windymilla merged 2 commits intoDistributedProofreaders:masterfrom Feb 26, 2026
Merged
Conversation
Collaborator
windymilla
commented
Feb 24, 2026
windymilla
commented
- Allow any combination of text/HTML files in either order
- Add checkboxes specific to processing files from the rounds.
rtonsing
reviewed
Feb 24, 2026
Contributor
rtonsing
left a comment
rtonsing
left a comment
There was a problem hiding this comment.
Tried one case of in-process text vs. text from rounds. Remove page seps, comments, and rejoin words all worked well.
And true, the online remove notes option does not work. Need to have a talk with the person that updated it a few years ago. :)
Collaborator
Author
|
Thanks Robert - I've kept the ppcomp.py file as close to the online version as I could, to make it easier if we want to transfer features between one version and another. Essentially, I've just left it to the PPer to be sensible and only turn on options that they want, where I think possibly the original had some knowledge of whether a file came from the rounds or not (always set to False in the online ppcomp code). |
1. Allow any combination of text/HTML files in either order 2. Add checkboxes specific to processing files from the rounds.
windymilla
force-pushed
the
ppcomp-text-files
branch
from
5bf54d3 to
b0976ed
Compare
Line numbers, order of different words & colors not always correct.
srjfoo
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.