SOV-5270: allow withdrawing supplied balances #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sovryn-layer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the ability for users to withdraw their supplied assets from the money market. The implementation includes a new withdraw dialog UI component, backend SDK support for withdrawal transactions, and necessary utility functions for amount calculations.
Key changes:
- Added
withdrawmethod to MoneyMarketManager SDK to handle withdrawal transactions for both native and non-native assets - Created WithdrawDialog component with form validation and maximum withdrawal calculation based on health factor requirements
- Introduced shared utilities including a
isFullAmounthelper andMINIMUM_HEALTH_FACTORconstant
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shared/src/lib/decimal.ts | Added MAX_UINT_256 constant to Decimal class for handling maximum withdrawal amounts |
| packages/sdk/src/managers/money-market/money-market.manager.ts | Implemented withdraw method with ABI definitions for withdraw and withdrawETH functions |
| apps/web-app/src/routes/money-market.tsx | Integrated WithdrawDialog component into the money market route |
| apps/web-app/src/lib/utils.ts | Added isFullAmount utility function for threshold-based amount comparisons |
| apps/web-app/src/components/ui/health-factor-bar.tsx | Updated to use shared MINIMUM_HEALTH_FACTOR constant |
| apps/web-app/src/components/MoneyMarket/stores/withdraw-request.store.ts | Created zustand store for managing withdrawal dialog state |
| apps/web-app/src/components/MoneyMarket/constants.ts | Defined MINIMUM_HEALTH_FACTOR constant (1.1) |
| apps/web-app/src/components/MoneyMarket/components/WithdrawDialog/WithdrawDialog.tsx | Implemented withdrawal dialog with form, validation, and health factor calculations |
| apps/web-app/src/components/MoneyMarket/components/LendPositionsList/components/AssetsTable/AssetsTable.tsx | Added withdraw button functionality to supply positions table |
| apps/web-app/src/components/MoneyMarket/components/LendDialog/LendDialog.tsx | Updated dialog description to be more descriptive |
| apps/web-app/src/components/MoneyMarket/components/BorrowDialog/BorrowDialog.tsx | Refactored to use shared MINIMUM_HEALTH_FACTOR constant |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/web-app/src/components/MoneyMarket/components/WithdrawDialog/WithdrawDialog.tsx
Outdated
Show resolved
Hide resolved
apps/web-app/src/components/MoneyMarket/components/WithdrawDialog/WithdrawDialog.tsx
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/web-app/src/components/MoneyMarket/components/WithdrawDialog/WithdrawDialog.tsx
Show resolved
Hide resolved
apps/web-app/src/components/MoneyMarket/components/WithdrawDialog/WithdrawDialog.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sovryn.atlassian.net/browse/SOV-5270