RS-18774: Remove dependency on ggplot2 #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@chschan the second screenshot does not show the tooltips? Could you provide a screenshot of the tooltip? |
Contributor
Author
|
Tooltips:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ggplot2 which originally was used to create the spline plot and then converted to plotly. This is needed because the the conversion code does not work with latest version of ggplot which is currently pinned and prevents another package requested by a user from being installed. Instead we directly create the spline plot in plotly. Note that the code for computing the mean, confidence interval and sampling draws has not changed, only the plotting code.
There is some difference in the new spline plots in that the font sizes has changed, but this now makes it consistent with the Bar/Column/Area charts, and we can add font controls to the javascript controls if it is requested
Old:
New:
