Gate OUTSIDE_FILES messaging on OUTSIDE_VIOLATION check#20
Merged
sethwv merged 1 commit intoDispatcharr:mainfrom Mar 30, 2026
Merged
Gate OUTSIDE_FILES messaging on OUTSIDE_VIOLATION check#20sethwv merged 1 commit intoDispatcharr:mainfrom
sethwv merged 1 commit intoDispatcharr:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the validation workflow and reporting script to more accurately detect and handle pull requests that modify files outside of the
plugins/directory. The changes ensure that warnings about modifying outside files are only triggered when an actual violation occurs, avoiding false positives.Workflow and script improvements:
.github/scripts/validate/report.shto only block merging and display a warning if bothOUTSIDE_FILESare present andOUTSIDE_VIOLATIONis true, ensuring stricter and more accurate enforcement..github/workflows/validate-plugin.ymlto pass the newOUTSIDE_VIOLATIONoutput from thedetect-changesjob to the validation scripts, supporting the improved logic in the reporting script.