Skip to content

Gate OUTSIDE_FILES messaging on OUTSIDE_VIOLATION check#20

Merged
sethwv merged 1 commit intoDispatcharr:mainfrom
sethwv:main
Mar 30, 2026
Merged

Gate OUTSIDE_FILES messaging on OUTSIDE_VIOLATION check#20
sethwv merged 1 commit intoDispatcharr:mainfrom
sethwv:main

Conversation

@sethwv
Copy link
Copy Markdown
Collaborator

@sethwv sethwv commented Mar 30, 2026

This pull request updates the validation workflow and reporting script to more accurately detect and handle pull requests that modify files outside of the plugins/ directory. The changes ensure that warnings about modifying outside files are only triggered when an actual violation occurs, avoiding false positives.

Workflow and script improvements:

  • Updated .github/scripts/validate/report.sh to only block merging and display a warning if both OUTSIDE_FILES are present and OUTSIDE_VIOLATION is true, ensuring stricter and more accurate enforcement.
  • Modified .github/workflows/validate-plugin.yml to pass the new OUTSIDE_VIOLATION output from the detect-changes job to the validation scripts, supporting the improved logic in the reporting script.

@dispatcharr-bot dispatcharr-bot bot added the Repo Update Scripts or other repository infrastructure. label Mar 30, 2026
@sethwv sethwv merged commit 82c4ea9 into Dispatcharr:main Mar 30, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Repo Update Scripts or other repository infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant