Skip to content

Update all OMIM Phenotypic Series xrefs#968

Closed
cthoyt wants to merge 1 commit intoDiseaseOntology:mainfrom
cthoyt:update-omim
Closed

Update all OMIM Phenotypic Series xrefs#968
cthoyt wants to merge 1 commit intoDiseaseOntology:mainfrom
cthoyt:update-omim

Conversation

@cthoyt
Copy link
Copy Markdown
Contributor

@cthoyt cthoyt commented Jul 6, 2021

This PR updates all cross-references to OMIM phenotypic series that are erroneously tagged with the OMIM namespace (done by replacing all "OMIM:PS" with "OMIMPS:PS"

Is there a prefix map that goes with DOID somewhere so I can include information about what this is for other people?

Closes #966

Related Updates to MGI repos

cthoyt added a commit to cthoyt/vocload that referenced this pull request Jul 7, 2021
I've sent DOID a pull request to use a more appropriate prefix for OMIM Phenotype series identifiers rather than grouping them with other OMIM terms. This change will make MGI's code both forward and backwards compatible.

See discussion at DiseaseOntology/HumanDiseaseOntology#968 and the related issue (linked in its description)
cthoyt added a commit to cthoyt/fewi that referenced this pull request Jul 7, 2021
I've sent DOID a pull request to use a more appropriate prefix for OMIM Phenotype series identifiers rather than grouping them with other OMIM terms. This change will make MGI's code both forward and backwards compatible.

See original discussion at DiseaseOntology/HumanDiseaseOntology#968 and the related issue (linked in its description)

Related: 
- mgijax/vocload#1
cthoyt added a commit to cthoyt/fewi that referenced this pull request Jul 7, 2021
I've sent DOID a pull request to use a more appropriate prefix for OMIM Phenotype series identifiers rather than grouping them with other OMIM terms. This change will make MGI's code both forward and backwards compatible.

See original discussion at DiseaseOntology/HumanDiseaseOntology#968 and the related issue (linked in its description)

Related: 
- mgijax/vocload#1
- mgijax#1
@lschriml
Copy link
Copy Markdown
Contributor

lschriml commented Jul 8, 2021

Hello Charles,
Thank you for your interest in the Human Disease Ontology.
Please send us requests for updates or revisions via our GitHub issues tracker.
Regarding this pull request, we are not planning on making this type of change in the OMIM cross references.
As the DO is used broadly, we have to careful consider all major changes to the data we represent, as these
changes can have significant downstream effects.

Regards,
Lynn Schriml
PI - Human Disease Ontology

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reference in DOID:0060681 deleted

2 participants