Skip to content

ENG-1149 add try / catch to migration when querying for relation patterns #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maparent wants to merge 3 commits into
base: eng-1135-replacing-sendmail-with-explicit-posthog-errors
Choose a base branch
from
Open

ENG-1149 add try / catch to migration when querying for relation patterns #624

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b88877
ENG-1149 try-catch when getRelationData fails
maparent Dec 18, 2025
20612bb
return value on catch
maparent Dec 18, 2025
25c7517
catch the promise, not above it
maparent Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions apps/roam/src/utils/getRelationData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import fireQuery from "./fireQuery";
import getDiscourseNodes from "./getDiscourseNodes";
import getDiscourseRelations from "./getDiscourseRelations";
import type { DiscourseRelation } from "./getDiscourseRelations";
import internalError from "./internalError";

// lifted from getExportTypes

Expand Down Expand Up @@ -39,14 +40,23 @@ export const getRelationDataUtil = async (
label: "target",
},
],
}).then((results) =>
results.map((result) => ({
source: result.uid,
target: result["target-uid"],
relUid: s.id,
label: s.label,
})),
);
})
.then((results) =>
results.map((result) => ({
source: result.uid,
target: result["target-uid"],
relUid: s.id,
label: s.label,
})),
)
.catch((error) => {
internalError({
error,
type: "Get relation data",
userMessage: `Could not find relations of type ${s.label}`,
});
return [];
});
}),
).then((r) => r.flat());

Expand Down