Skip to content

[ENG-1168] Preserve list indicators in node tag flow #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trangdoan982 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[ENG-1168] Preserve list indicators in node tag flow #619

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
360e6f2
preserve list indicator
trangdoan982 Dec 15, 2025
5e8c931
address PR comments
trangdoan982 Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions apps/obsidian/src/utils/tagNodeHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,23 @@ const HIDE_DELAY = 100;
const OBSERVER_RESTART_DELAY = 100;
const TOOLTIP_OFFSET = 40;

const LIST_INDICATOR_REGEX = /^(\s*)(\d+[.)]\s+|[-*+]\s+(?:\[[ xX]\]\s+)?)/;

const sanitizeTitle = (title: string): string => {
const invalidChars = /[\\/:]/g;

// Remove list item indicators (numbered, bulleted, etc.)
const listIndicator = /^(\s*)(\d+\.\s+|-\s+|\*\s+|\+\s+)/;

return title
.replace(listIndicator, "")
.replace(LIST_INDICATOR_REGEX, "")
.replace(invalidChars, "")
.replace(/\s+/g, " ")
.trim();
};

const extractListPrefix = (line: string): string => {
const match = line.match(LIST_INDICATOR_REGEX);
return match ? match[0] : "";
};

type ExtractedTagData = {
fullLineContent: string;
tagName: string;
Expand Down Expand Up @@ -350,9 +354,11 @@ export class TagNodeHandler {
return;
}

// Replace the entire line with just the discourse node link
const listPrefix = extractListPrefix(actualLineText);
const replacementText = listPrefix + linkText;

editor.replaceRange(
linkText,
replacementText,
{ line: lineNumber, ch: 0 },
{ line: lineNumber, ch: actualLineText.length },
);
Expand Down