fix: console.error() when the App and/or token isn't coordinate#177
Merged
ValDesign22 merged 2 commits intoDiscordAnalytics:masterfrom Jul 23, 2025
Merged
fix: console.error() when the App and/or token isn't coordinate#177ValDesign22 merged 2 commits intoDiscordAnalytics:masterfrom
ValDesign22 merged 2 commits intoDiscordAnalytics:masterfrom
Conversation
ValDesign22
requested changes
Jul 21, 2025
src/discordjs/index.ts
Outdated
| public async trackInteractions(interaction: any, interactionNameResolver?: (interaction: any) => string) { | ||
| if (this._debug) console.log("[DISCORDANALYTICS] trackInteractions() triggered") | ||
| if (!this._isReady) throw new Error(ErrorCodes.INSTANCE_NOT_INITIALIZED) | ||
| if (!this._isReady) console.error(ErrorCodes.INSTANCE_NOT_INITIALIZED) |
Member
There was a problem hiding this comment.
This is a good idea, but to avoid sending stats when the error is sent a return must be used
if (!this._isReady) return console.error(ErrorCodes.INSTANCE_NOT_INITIALIZED)
thomasbnt
commented
Jul 22, 2025
Member
|
Merged, and applied it to the new monorepo |
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.