Enable pausing and resuming of stream#93
Enable pausing and resuming of stream#93yannikwirbs wants to merge 1 commit intoDiscord-RE:masterfrom
Conversation
Video and audio output pipe are on hold while paused.
|
I'm wondering how this will behave in an actual live stream, and whether stream backpressure will be a problem. Repeating the last frame is definitely not possible, since it'll break the bitstream. |
|
|
|
This will also only work if From looking at eloquent-ffmpeg it seems it just suspends the process and then resumes it, like some people were already doing using |
And it also works on Windows using the undocumented I also wonder how the functionality should be exposed to user code. Maybe we'd need to create some kind of playback controller object, with |
|
@longnguyen2004 while implementing ffmpeg api in nodejs maybe make a pause function that stores current timecode of demuxing and continue from there if possible. Not sure if SIGSTOP and SIGCONT is that reliable. |
|
Anybody taken a look at this recently? Would be nice if this was built-in to the library. |
|
What problems are there? I am by no means familiar with ffmpeg, but it seemed like a good idea suspending the callback. The only things coming to my mind that might be causing problems for long periods is the pipe breaking or ffmpeg to stop after long idle, right? But I get that you would rather have proper handling. It's been some time, do you want to close the PR? |
|
I'll close it when I can come up with something better. Maybe it'll be something over at https://github.com/Discord-RE/FFmpeg-input-premade that integrates CasparCG for a complete solution |
Video and audio output pipe are on hold while paused.
There is no video or audio in discord.
Maybe there is a way to implement a way to send a still image to the video.
Video and audio are not desyncing.
REFERENCE ISSUE: #5