Skip to content

fix: iron out warnings/errors/deprecations from PHP 8.0 upgrade #1384 #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corsacca merged 2 commits into from
Aug 5, 2021
Merged

fix: iron out warnings/errors/deprecations from PHP 8.0 upgrade #1384 #1402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
524f37a
fix: return -1, 0, 1 from uksort and uasort callbacks
squigglybob May 27, 2021
96ea022
fix: deprecated parameter order from PHP8
squigglybob May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion archive-template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ class="second-bar show-for-small-only center list-actions-bar"><!-- /* MOBILE V
if ( isset( $b["show_in_table"] ) ){
$b_order = is_numeric( $b["show_in_table"] ) ? $b["show_in_table"] : 90;
}
return $a_order > $b_order;
return $a_order <=> $b_order;
});
foreach ( $post_settings["fields"] as $field_key => $field_value ){
if ( ( isset( $field_value["show_in_table"] ) && $field_value["show_in_table"] ) ){
Expand Down
2 changes: 1 addition & 1 deletion dt-contacts/access-module.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ public function dt_custom_fields_settings( $fields, $post_type ){

//order overall status options
uksort( $declared_fields["overall_status"]["default"], function ( $a, $b ) use ( $fields ){
return array_search( $a, array_keys( $fields["overall_status"]["default"] ) ) > array_search( $b, array_keys( $fields["overall_status"]["default"] ) );
return array_search( $a, array_keys( $fields["overall_status"]["default"] ) ) <=> array_search( $b, array_keys( $fields["overall_status"]["default"] ) );
} );
$fields = $declared_fields;
}
Expand Down
6 changes: 5 additions & 1 deletion dt-core/libraries/posts-to-posts/vendor/scribu/scb-framework/Cron.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ class scbCron {
*
* @return void
*/
public function __construct( $file = false, $args ) {
public function __construct( $file = false, $args = array() ) {

if ( empty( $args ) ) {
return;
}

// Set time & schedule
if ( isset( $args['time'] ) ) {
Expand Down
3 changes: 1 addition & 2 deletions dt-core/libraries/posts-to-posts/vendor/scribu/scb-framework/Forms.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public static function form_table( $rows, $formdata = null ) {
*
* @return string
*/
public static function form( $inputs, $formdata = null, $nonce ) {
public static function form( $inputs, $formdata = null, $nonce = 'update_options' ) {
$output = '';
foreach ( $inputs as $input ) {
$output .= self::input( $input, $formdata );
Expand Down Expand Up @@ -1045,4 +1045,3 @@ public function validate( $value ) {
return call_user_func( $this->sanitize, $value, $this );
}
}