feat: Window Manager APIs #302
Conversation
JakkuSakura
force-pushed
the
window-manager
branch
4 times, most recently
from
ef372fb to
1a18f2d
Compare
JakkuSakura
force-pushed
the
window-manager
branch
4 times, most recently
from
e4ae582 to
700e3f7
Compare
nicoburns
left a comment
nicoburns
left a comment
There was a problem hiding this comment.
I have some comments about thread synchronisation. In addition to that, we're hoping to align the API with the one from Dioxus Desktop, so that users could use the same code with either Desktop or Native.
https://docs.rs/dioxus-desktop/latest/dioxus_desktop/fn.use_window.html
https://docs.rs/dioxus-desktop/latest/dioxus_desktop/struct.DesktopService.html#method.new_window
examples/multi_window.rs
Outdated
| let vdom = VirtualDom::new(secondary_window); | ||
| let title = format!("window#{}", counter()); | ||
| let attributes = WindowAttributes::default() | ||
| .with_title(title) | ||
| .with_inner_size(winit::dpi::LogicalSize::new(400.0, 300.0)); | ||
| let receiver = provider.create_document_window(vdom, attributes); | ||
| let mut spawned_windows = spawned_windows.clone(); |
There was a problem hiding this comment.
I wonder whether create_document_window should accept a "function that returns a VirtualDom" (similar to launch) rather than an already constructed VirtualDom? That might eliminate the thread-safety issues?
There was a problem hiding this comment.
Maybe not able to elimate thread-safety issues. It's because BlitzShellEvent::embedder_event still requires Send + Sync
JakkuSakura
force-pushed
the
window-manager
branch
from
a869957 to
18f4863
Compare
2 participants
This PR introduces multi-window management and easy to use API and example