Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f5553ac9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ! command -v adb >/dev/null 2>&1; then | ||
| echo "adb is not available in PATH." >&2 | ||
| exit 1 |
There was a problem hiding this comment.
Source Android env before checking adb
install_android_apk.sh checks for adb immediately, but unlike the other new Android scripts it never sources scripts/android_env.sh or calls ensure_android_env(). In environments where adb is only available under a standard SDK path (for example ~/Library/Android/sdk/platform-tools) and not already on PATH, this script exits with "adb is not available" even though the same repo’s Android build/dev scripts work, so install/launch is broken for a common setup.
Useful? React with 👍 / 👎.
|
Closing: opened unintentionally. Keeping branch on fork. |
|
sorry, this is not PR worthy yet, codex was overeager to push a PR I didn't ask for. I am using it as of today though on the galaxy fold 7, and it is working great! thanks Dimillian |
Adds Android mobile support scaffolding and docs.