feat(settings): add Codex update button (brew/npm)#364
feat(settings): add Codex update button (brew/npm)#364Dimillian merged 7 commits intoDimillian:mainfrom
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f0cc74532
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Follow-up: fixed in commit 97ecd9e. App now passes the codexUpdate handler from useAppSettingsController into SettingsView (settingsProps.onRunCodexUpdate), so the Update button uses the real Tauri update path. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88c0c39ec9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed the new Codex feedback in commit 3b33998: detection now treats missing brew/npm binaries as not-installed during method probing, so the flow no longer aborts early and can fall back to npm/unknown. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b33998f8d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed the latest Codex feedback in commit 3887895: the pre-update codex version check is now best-effort (non-fatal), so update method detection and upgrade can proceed even when the configured codex binary/path is invalid. |
Co-authored-by: shaw-baobao <1175745159@qq.com> Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
This PR adds a simple "Update" action next to "Run doctor" in Settings → Codex.
What it does
codex_updatethat updates Codex based on detected install method:brew upgrade --cask codexbrew upgrade codex@openai/codexis installed, runsnpm install -g @openai/codex@latestmethod: "unknown"with a helpful message.Why
Testing
Notes